docs(#4368): add migration robustness patterns to boost AGENTS.md - #4369
Merged
Conversation
Add a "Migration patterns" subsection under "Code conventions" documenting four robustness requirements for connector schema migrations: per-step version stamping for resumability, per-entity error isolation so one connector failure does not block others, original error preservation when cleanup also fails, and treating missing __schemaVersion as v1. These patterns codify the human fixes from PR #4315 (commits 19c5c9b and 5bc131d) so future migration work follows the established robustness conventions without manual correction. Closes #4368
fullsend-ai-coder
Bot
requested review from
a team,
gabemontero,
johnmcollier,
jordigilh,
mareklibra and
rohitkrai03
as code owners
August 18, 2026 07:12
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4369 +/- ##
=======================================
Coverage 61.53% 61.53%
=======================================
Files 2528 2528
Lines 101564 101564
Branches 28423 28435 +12
=======================================
Hits 62496 62496
Misses 37262 37262
Partials 1806 1806
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
gabemontero
approved these changes
Aug 18, 2026
|
🤖 Finished Retro · ✅ Success · Started 1:15 PM UTC · Completed 1:23 PM UTC Commit: |
Retro: PR #4369 — docs(#4368): add migration robustness patterns to boost AGENTS.mdVerdict: Clean workflow, no new proposals. All identified improvement opportunities are already tracked by existing open issues. What happenedThis PR is part of a well-functioning retro-to-code feedback loop. The retro agent analyzed PR #4315 (connector schema versioning, +790/-18 across 17 files) and correctly identified three robustness gaps in The full pipeline executed cleanly:
Observations mapped to existing issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "Migration patterns" subsection under "Code conventions" documenting four robustness requirements for connector schema migrations: per-step version stamping for resumability, per-entity error isolation so one connector failure does not block others, original error preservation when cleanup also fails, and treating missing __schemaVersion as v1.
These patterns codify the human fixes from PR #4315 (commits 19c5c9b and 5bc131d) so future migration work follows the established robustness conventions without manual correction.
Closes #4368
Post-script verification
agent/4368-migration-patterns-agents-md)238b1a3a6799a81dab6c9af3f2b180688372781f..HEAD)