Skip to content

brand: ship the 2026 Redrob Code app icon - #126

Merged
its-janghoon merged 1 commit into
developfrom
feat/app-icons-2026
Oct 20, 2026
Merged

its-janghoon merged 1 commit into
developfrom
feat/app-icons-2026

Conversation

@its-janghoon

Copy link
Copy Markdown
Member

What's done

  • Replaced the upstream geometric mark in packages/identity with the 2026 Redrob Code app icon from @redrob-labs/ui@1.8.0 (dist/brand/app-icons/redrob-code), byte for byte.
    • mark.svg and packages/docs/favicon.svg = redrob-code-icon-web.svg (sha256 0a9840bb…dcc)
    • mark-light.svg = redrob-code-icon-web-dark.svg (sha256 c9dd2dff…e57)
    • mark-{96x96,192x192,512x512}.png = icon-web rendered with Chromium at 1024 px, then resized; mark-512x512-light.png = icon-web-dark.
  • Everything that ships the app icon reads these files, so it all changes at once:
    • Redrob Launcher: the release copies mark-512x512.png to redrob-code.png, the icon in redrob-launcher.json. No workflow change needed.
    • VS Code extension: sdks/vscode/images/icon.png and both toolbar buttons are symlinks into packages/identity.
    • Docs site favicon.
  • Gate (run once): bun install --frozen-lockfile, brand-tokens.test.ts (15 pass), launcher-assets.test.ts (7 pass), oxlint (0 errors).

What's not done

  • The Windows (Inno/WiX) and macOS dmg installers ship no icon today, and this PR does not add one.
  • The docs wordmark (logo-ornate-*.svg) is unchanged; it is a wordmark, not the app icon.
  • No full typecheck or test suite: the diff only touches assets.

What to review

  • Using the masked -icon-web variant (transparent superellipse corners) rather than the square -icon tile. Every consumer shows the PNG as is (launcher catalog, Linux menu entry, VS Code marketplace, favicon), so the square tile would show hard corners.
  • mark-light.svg / mark-512x512-light.png now hold the dark-appearance icon, which matches how VS Code uses button-light.svg (on the dark theme).

Intentions

The launcher and the OS should show the new Redrob Code icon from the next release, and no upstream mark should be left in the product.

Replace the upstream geometric mark in packages/identity (and everything that
reads it) with the Redrob Code icon from @redrob-labs/ui@1.8.0,
dist/brand/app-icons/redrob-code, copied byte for byte.

- packages/identity/mark.svg, packages/docs/favicon.svg:
  redrob-code-icon-web.svg
  sha256 0a9840bb44ac1307014d59b9e33e279b1568cbf51137745a437d7c4fbd755dcc
- packages/identity/mark-light.svg (the VS Code dark-theme button):
  redrob-code-icon-web-dark.svg
  sha256 c9dd2dff9c6e4bc274c42f2d41856b573d659a55941aa30af0ca81421f249e57
- packages/identity/mark-{96x96,192x192,512x512}.png: icon-web rendered with
  Chromium at 1024 px, Lanczos-resized. mark-512x512.png is the asset the
  release uploads as redrob-code.png for Redrob Launcher (redrob-launcher.json
  "icon"), and the VS Code extension icon (sdks/vscode/images/icon.png links to it).
- packages/identity/mark-512x512-light.png: icon-web-dark, same render.

The masked web variant is used because every consumer shows the PNG as is
(launcher catalog, Linux menu entry, VS Code marketplace, docs favicon); the
unmasked -icon tile would show square corners there.
@its-janghoon
its-janghoon merged commit 501dd3f into develop Oct 20, 2026
17 checks passed
its-janghoon added a commit that referenced this pull request Oct 20, 2026
Release of #126 (2026 app icon) and #127 (thin PR CI).
@its-janghoon
its-janghoon deleted the feat/app-icons-2026 branch October 20, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant