Repository navigation
Promote develop to main (v0.12.1: daemon cwd fix) - #131
Merged
Merged
Conversation
Sync main back into develop (v0.12.0)
The shared daemon was spawned with no cwd, so it inherited the caller's: an
app's install folder (e.g. Canvas's bin\), held open for the daemon's whole
life, which blocks that app's Windows update ("folder in use").
- daemon/connect.ts: spawn `serve --register` with cwd = home.
- sdk daemon.ts: spawn `service start` with cwd = home.
- serve --register: chdir to home at start (try/catch), covering older
callers that still spawn it from an app folder.
- Windows installer: PrepareToInstall runs `{app}\redrob.exe service stop`
(failure ignored) so a running daemon does not block overwriting redrob.exe.
fix: daemon no longer holds the caller's working directory
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done
serve --registerchdirs to home), and the Windows installer stops a running daemon before overwritingredrob.exe.What's not done
What to review
Intentions