Repository navigation
Design leftovers: board glyphs, dashboard status, phone padding, tertiary buttons - #521
Merged
Merged
Conversation
Contributor
[Medium impact] The PR changes several user-facing views and adds a status-update path on the dashboard. Fix the stale dashboard goal summary and satisfy the repository's async-result and comment requirements before merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Four small design leftovers from the Phase 1 and status-layout work, in one PR.
Changes
statusColoris removed; nothing else used it.p-4 sm:p-6), per design-system.md › Mobile. Actions keeps its edge-to-edge phone layout from Give the Actions page 16px padding on phones #516.tertiarytext buttons: 15 text buttons (Cancel, Clear, Dismiss, Restore, Resend, View N more, View all goals, Show more) move fromghosttotertiary, dropping theirtext-muted-foregroundoverrides so they take the variant's color. Icon buttons stayghost. Prototype pages are untouched.actionErrorMessage, which the dashboard shares too. As a side effect, the session panel shows the permission message on a 403, as the Actions page already did. Goal progress refresh is shared asuseRevalidateGoalProgress.Screenshots / Videos Showing UI Changes (if applicable)
Helpful: Actions board headers; the dashboard session detail with the status menu open; Dashboard at 375px; a Cancel button at rest and on hover.
Testing Strategy
npx tsc --noEmit, lint, all unit tests pass; action, suggested-action, member and session e2e specs pass on Chromium.mainpadding is 16px at a true 375px on Dashboard and Settings, 24px on desktop.Concerns
tertiarybuttons are a shade darker at rest than before (#525252 instead of #737373) and no longer fill on hover. That's the variant's spec from the Phase 1 review.