Skip to content

Design leftovers: board glyphs, dashboard status, phone padding, tertiary buttons - #521

Merged
jhodapp merged 7 commits into
mainfrom
feat/design-leftovers
Nov 2, 2026
Merged

jhodapp merged 7 commits into
mainfrom
feat/design-leftovers

Conversation

@jhodapp

@jhodapp jhodapp commented Nov 2, 2026

Copy link
Copy Markdown
Member

Description

Four small design leftovers from the Phase 1 and status-layout work, in one PR.

Changes

  • Actions board headers: each column header shows its status glyph instead of the old colored dot. statusColor is removed; nothing else used it.
  • Status from the dashboard: the session detail's action rows can now change status from the glyph or pill, like the session panel. Saving refreshes the action lists and, for goal-linked actions, goal progress. A failure shows "Couldn't update the status".
  • Phone padding: Dashboard, Settings, Admin, Organization members and Member profile use 16px page padding on phones (p-4 sm:p-6), per design-system.md › Mobile. Actions keeps its edge-to-edge phone layout from Give the Actions page 16px padding on phones #516.
  • tertiary text buttons: 15 text buttons (Cancel, Clear, Dismiss, Restore, Resend, View N more, View all goals, Show more) move from ghost to tertiary, dropping their text-muted-foreground overrides so they take the variant's color. Icon buttons stay ghost. Prototype pages are untouched.
  • Refactor: the Actions page and session panel each had their own action error message helper; both now use actionErrorMessage, which the dashboard shares too. As a side effect, the session panel shows the permission message on a 403, as the Actions page already did. Goal progress refresh is shared as useRevalidateGoalProgress.

Screenshots / Videos Showing UI Changes (if applicable)

Helpful: Actions board headers; the dashboard session detail with the status menu open; Dashboard at 375px; a Cancel button at rest and on hover.

Testing Strategy

  • Unit: dashboard status change (save, goal-progress refresh, failure toast). Updated the hover detail and mocks for the shared hooks.
  • npx tsc --noEmit, lint, all unit tests pass; action, suggested-action, member and session e2e specs pass on Chromium.
  • Live backend: board headers show glyphs; changing an action's status from the dashboard saved and survived a reload (restored afterwards); main padding is 16px at a true 375px on Dashboard and Settings, 24px on desktop.

Concerns

  • tertiary buttons are a shade darker at rest than before (#525252 instead of #737373) and no longer fill on hover. That's the variant's spec from the Phase 1 review.

@jhodapp jhodapp self-assigned this Nov 2, 2026
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Nov 2, 2026
@jhodapp jhodapp added this to the 1.0.0-beta4 milestone Nov 2, 2026
@jhodapp
jhodapp marked this pull request as ready for review November 2, 2026 21:48
@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR changes several user-facing views and adds a status-update path on the dashboard.

Fix the stale dashboard goal summary and satisfy the repository's async-result and comment requirements before merging.

Fix All in Claude CodeFindings

  1. P1 Dashboard goal counts stay stale ▶
  2. P2 Status errors lack typed results ▶
  3. P2 Comment repeats the code ▶

Summary

Adds dashboard action-status controls and shares action error messages and goal-progress refresh code.

  • Dashboard session action rows can save a new status.
  • Action errors share messages for permission and network failures.
  • Dashboard and account pages use tighter phone gutters.
  • Actions board columns show status glyphs beside their labels.
  • Text actions use the tertiary button style across session, dashboard, and member pages.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[User changes dashboard action status] --> B[Action update succeeds]
  B --> C[Action lists refresh]
  B --> D{Action links to a goal?}
  D -->|Yes| E[Goal progress refresh filter]
  E --> F[Single-goal progress matches]
  E --> G[Dashboard goal-progress list does not match]
  G --> H[Dashboard summary stays stale]
Loading

Reviews (1) · Last reviewed commit: "refactor(design): use the tertiary varia..." · Reviewed by Greptile

Comment thread src/lib/api/goal-progress.ts Resolved
@jhodapp
jhodapp merged commit 39fc4d0 into main Nov 2, 2026
11 checks passed
@jhodapp
jhodapp deleted the feat/design-leftovers branch November 2, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves existing functionality or feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant