[jhodapp]

Description

Fifth of six PRs for the stepped "New session" dialog. Reschedule now opens the same dialog in move mode, on a dashboard row, a bucket row or the Upcoming card. The old "Update Coaching Session" dialog and form are deleted. Stacked on #525.

Changes

• Move mode:
  • The title is "Reschedule session". The rail shows the person and "Currently Tue, Nov 3, 1:00 PM".
  • There's no Who step. The dialog starts on the session's date, time and length.
  • The session being moved doesn't count as busy against itself.
  • "Pick a new date or time." shows until something changes, then the confirm is "Reschedule session".
  • A clash adds Resolve overlap, as in schedule mode.
• Saving: a single update of the same session, so its notes and topics stay. A series session moves on its own; "This and following" waits for the backend endpoint (PR 7). The toast reads "Rescheduled · Caleb to Thursday, November 5, 1:00 PM".
• Store: openMoveSession(session), ready for the session page header and Progress rows later.
• Shared code: both modes use one submit path. Only the first write, the error wording and the success message differ by mode.
• Removed: CoachingSessionDialog, CoachingSessionForm, sessionUpdatedMessage and their tests. The error cases not covered elsewhere were ported to dialog tests.
• Docs: the dialog test plan gains Part G (move mode); design-system plan Case E5 updated.

Screenshots / Videos Showing UI Changes (if applicable)

Useful: Reschedule from a row before and after picking a new day, and a move that clashes with another session.

Testing Strategy

• Specs written first for move mode and the store. All 2705 tests pass; tsc and lint are clean.
• Real browser against a local backend: Reschedule on the Upcoming card opened move mode with the right person, current time and length. Moving to another day sent one update of the same session, showed the toast, and moved the row without a reload.
• Manual: docs/test-plans/new_session_dialog_manual_testing.md Part G.

Concerns

• "Edit series" still uses the series update that re-creates future sessions. PR 7 replaces it once the backend endpoint lands.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no actionable issues found.

Summary

Reschedule now opens the shared New session dialog in move mode.

• Dashboard rescheduling now opens the shared stepped session dialog.
• Step arrows stay visible and disable at the ends of the dialog.
• Duration controls step out-of-range values to the nearest bound first.

No actionable issues were found. This assessment includes caller checks in PR #527. No runtime or browser verification was performed.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Dashboard or Upcoming Reschedule] --> B[openMoveSession]
  B --> C[Shared dialog starts on When]
  C --> D[Exclude current session from busy times]
  D --> E{Overlap?}
  E -->|Yes| F[Resolve overlap]
  E -->|No| G[Confirm move]
  F --> G
  G --> H[Update the same session]
  H --> I[Move other session if chosen]
  I --> J[Refresh session views and close]

Loading

_{Reviews (1) · Last reviewed commit: "fix(scheduling): step a length outside t..." · Reviewed by Greptile}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.