Repository navigation
feat: add structured scalar evaluation diagnostics - #16
Merged
Merged
Conversation
roncohen
force-pushed
the
feat/latest-error-diagnostics
branch
from
October 6, 2026 17:09
824f736 to
a33ad49
Compare
roncohen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured, non-fatal scalar evaluation diagnostics and pre-initialization check diagnostics. Based on freshly fetched
main(5e40623).INVALID_CONTEXT_VALUE,INVALID_TARGETING_VALUE, andUNKNOWN_OPERATOR, with field/operator metadata and messages that omit raw context/comparison values.CLIENT_NOT_INITIALIZEDto online check telemetry, including override checks, without adding it to bootstrap results. Suppress initialization errors in offline mode.evaluationErrors) and check telemetry (evalErrors), rate-limit warnings by diagnostic identity, and document the diagnostic codes.Verification
dotnet format dotnet-sdk.sln --verify-no-changes --severity warn --no-restoredotnet build dotnet-sdk.sln --configuration Release --no-restore -warnaserror(includingnetstandard2.0)dotnet test dotnet-sdk.sln --configuration Release --no-build --logger "console;verbosity=minimal"— 205 SDK tests + 5 example tests pass on each of .NET 8 and .NET 10git diff --checkRegression coverage includes invalid context vs targeting values, relative-date offsets, numeric infinity semantics, unknown/malformed operators, fallback snapshot round trips, fail-closed rules, healthy sibling flags, bootstrap/check wire payloads, warning deduplication, pre-initialization/override checks, disabled telemetry, and offline access.