fix: skip TLS 1.2 resumption on extended_master_secret mismatch - #417
Open
thesinakamali wants to merge 1 commit into
Open
thesinakamali wants to merge 1 commit into
thesinakamali wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadSessiondoes not compare the cached session'sextended_master_secretstate against the ClientHello being sent. AClientHelloSpecthat omits the EMS extension could pair with a cached session established with EMS, and the server then aborts (handshake_server.go already enforces this). Fix by skipping resumption on a mismatch so the connection proceeds with a full handshake using the selected spec.This requires
ApplyPresetto stop leavinghello.Emsat themakeClientHellodefault of true. It is now cleared when the preset is applied and set again byExtendedMasterSecretExtension.writeToUConnonly when the spec carries the extension, sohello.extendedMasterSecretreflects what is on the wire. This is the same behavior #307 aimed for, and doing it inApplyPresetrather than inmakeClientHelloForApplyPresetkeeps it in uTLS-only code, so it isn't affected by future stdlib syncs.