feat: add ClientHello record fragmentation - #419
Open
thesinakamali wants to merge 1 commit into
Open
thesinakamali wants to merge 1 commit into
thesinakamali wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Config.FragmentClientHellocallback that, when set, splits the ClientHello across two TLS handshake records instead of sending it in one. The callback receives the marshaled ClientHello and returns the offset to split at; returning an offset outside0 < n < lensends a single record, so callers can decide per connection. This mainly addresses middleboxes that pattern match on the ClientHello without reassembling the record layer. If the field is nil, behavior is unchanged.Fragmentation is applied only to client side non-QUIC, non-ECH ClientHellos in the initial handshake, which includes
HelloRetryRequestretries but not renegotiation. Splitting a handshake message across records is permitted by RFC 8446, Section 5.1.Changes:
ClientHelloFragFunctype andFragmentClientHellofield toConfigin common.goFragmentClientHelloinConfig.Clone()ClientHelloFragmentedfield toConnectionMetricsin common.goshouldFragmentClientHelloandwriteFragmentedClientHellotoConnin u_client_hello_fragmentation.go