docs(email-security): retention is a setting that deletes, and it has two lanes - #379
Merged
Conversation
maximelb
marked this pull request as ready for review
September 5, 2026 17:40
Contributor
Author
|
/lc-review |
lcbill
previously approved these changes
Sep 5, 2026
… two lanes The retention section described a knob that had no effect: it documented a maximum-wins composition (which, with the default at the ceiling, could never resolve to anything but the ceiling) and told the reader the message index was not configurable. Both are now false. - `message_days` (1-35) beside `flagged_days` (1-400), with what each lane actually governs, because 'keep my queue for a week' and 'keep my phishing evidence for a week' are different asks. - the ceilings, the one-day floor, and that both are refused rather than clamped. - what deletion actually removes, that it is permanent, and the two consequences a customer will otherwise discover by surprise (a backlog drains over several sweeps; setting the evidence lane below the message lane leaves index entries without a downloadable copy). - composition takes the MINIMUM: the strictest record wins, toward holding less of the customer's mail.
maximelb
force-pushed
the
m2ret-retention
branch
from
September 6, 2026 01:53
fdd62cf to
6fda197
Compare
Contributor
Author
|
/lc-review |
lcbill
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
retentionsection documented a setting that did nothing. Two of its statements were false in the customer's disfavour:flagged_days: 30andflagged_days: 200both resolved to 400 and no record could ever shorten anything.Backing change: go-mailsec#93 and legion_mailsec (the retention janitor's second duty) make the knob actually delete, below the store's own ceilings. This PR makes the docs describe what the product does.
What changes
policy.md→retention: both fields with what each lane governs; the ceilings and the one-day floor, both refused rather than clamped; what deletion actually removes and that it is permanent; and composition taking the minimum — the strictest record wins, toward holding less of the customer's mail.flagged_daysbelowmessage_daysleaves index entries whose stored copy is already deleted (which is what they asked for, but is worth saying).messages.md/pipeline.md: the two lanes are now labelled with the field that shortens each, and "tunable" is corrected to "tunable downwards, and what falls past the horizon is deleted".Notes
retentionsection inpolicy.mdand the retention block inpipeline.md. Whichever lands second needs a small rebase — say the word and I will do it. The two are complementary: docs(email-security): document the tenant purge #378 is deletion on request, this is deletion on a clock the customer sets.Public repo — opening for review only, not merging.