Skip to content

fix: clear the open security alerts and update dependencies - #288

Merged
ManukMinasyan merged 5 commits into
3.xfrom
chore/security-and-deps-2026-11
Nov 6, 2026
Merged

ManukMinasyan merged 5 commits into
3.xfrom
chore/security-and-deps-2026-11

Conversation

@ManukMinasyan

Copy link
Copy Markdown
Member

This clears every open security alert on custom-fields except one, and brings each dependency to its latest compatible version, before v3.16.3 is tagged. Dependabot reports four npm alerts in the docs site (high: zod; medium: minimatch, glob; low: deepmerge). Code scanning reports one zizmor finding in release.yml. This PR fixes all of them except deepmerge, which has no patched release. There are no repository advisories and no secret-scanning alerts.

None of the npm alerts reach the package itself. They sit in docs/, the Nuxt site that builds the documentation, which Composer users never install.

What changed

  • docs/package.json overrides (Dependabot feat: version the entity registry cache key #295, #335, #337):
    • zod resolves to the site's own ^4.6.7 ($zod). @nuxt/content 3.16.2, its latest release, still requires zod 3, and zod 3 has no patched release, so forcing zod 4 is the only fix.
    • minimatch resolves to ^11.0.5 (all copies were 10.2.6, affected range 7.0.0 to 11.0.0).
    • glob resolves to ^14.0.4 (copy 13.0.7, affected range 9.0.0 to 14.0.1).
  • docs/package-lock.json and package-lock.json: updated within their ranges. Notable moves: nuxt 4.6.4, @nuxt/image 2.2.1, tailwindcss and @tailwindcss/postcss 4.3.4.
  • resources/dist/custom-fields.css: rebuilt. The committed file dated from 2026-10-05, and 16 commits have touched src/ and resources/views since. Rebuilding with the old lockfile also gives about 824 KB against 798 KB committed. So the growth comes from source and Filament theme changes, and tailwind 4.3.4 adds only 172 bytes.
  • release.yml (code scanning Add infolists components and factories for custom fields #11): calls tests.yml through GitHub's self-repository syntax uses: $/.github/workflows/tests.yml. That form can't load a workflow cloned at runtime, and GitHub treats it as pinned.
  • tests.yml: the "Actions pinned to SHA" check now exempts $/ references as well as ./ ones. Without this, the check fails on release.yml.
  • zizmor.yml: zizmorcore/zizmor-action v0.8.0 to v0.8.1. Every other pinned action was already at its latest release.

Why this way

npm audit fix only offers semver-major downgrades of docus, nuxt and @nuxt/ui, so overrides on the vulnerable leaves are the smallest fix that keeps the site on current versions.

Behavior to know about

  • Composer: no change to composer.json. A fresh composer update installs Filament 5.11.1 and Laravel 13.40.0, every direct dependency is at its latest, Rector's pin (2.8.4) is its latest release, and composer audit finds nothing.
  • deepmerge (Dependabot #324, low): stays open. Every release from 4.2.0 is affected, and no fix exists. It reaches the docs build only through @rollup/plugin-node-resolve inside nitropack, which merges its own options, not user input. The nine low findings left in npm audit for docs/ are all this one package and the packages that depend on it.
  • No migration, no config key.

Checked

On 9c9226f8:

  • Package suite: vendor/bin/pest --parallel passes 1123 (3 todo), PHPStan reports no errors, Rector and Pint pass.
  • npm: npm ci succeeds in the root and in docs/. Root npm audit finds 0 vulnerabilities. Docs npm audit finds 9 low, all deepmerge, down from 22 (5 high).
  • Root build: npm run build builds the stylesheet and script.
  • Docs build with CI's environment (NUXT_SITE_URL, NUXT_APP_BASE_URL=/custom-fields/): npm run generate prerenders 74 routes. A spot check of essentials/builder-scoping.html shows its markdown rendered, so @nuxt/content works on zod 4.
  • The $/ syntax: proven on a throwaway branch that called tests.yml with uses: $/.... Its matrix jobs started, and its pin check failed on the $/ line, which is why tests.yml changed. I cancelled the run and deleted the branch.

Not checked

  • release.yml itself runs only on a tag push, so the first exercise of the changed line is the v3.16.3 tag. The throwaway run proved the same call shape.
  • The 4.x branch is not covered here. Dependabot reports against 3.x, the default branch.

@nuxt/content still requires zod 3, which has no patched release, so the docs force zod 4. minimatch moves to 11.0.5 and glob to 14.0.4. The rest of the docs lockfile is updated within its ranges.
The pin check now exempts $/ references, which GitHub treats as pinned.
Copilot AI balanced review requested due to automatic review settings November 6, 2026 12:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan added this pull request to the merge queue Nov 6, 2026
Merged via the queue into 3.x with commit e6c3da9 Nov 6, 2026
9 checks passed
@ManukMinasyan
ManukMinasyan deleted the chore/security-and-deps-2026-11 branch November 6, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants