Skip to content

fix(fields): stack the entity tabs above the fields and floor the name column on phones - #290

Merged
ManukMinasyan merged 1 commit into
3.xfrom
fix/fields-settings-on-phones
Nov 6, 2026
Merged

ManukMinasyan merged 1 commit into
3.xfrom
fix/fields-settings-on-phones

Conversation

@ManukMinasyan

Copy link
Copy Markdown
Member

On a phone, the custom fields screen now puts the entity tabs in a scrollable row above the fields, and the field name column stays at least 10rem wide. Before, the vertical tabs sat beside the table and left it about 140px. Inside that, the name column was the 1fr track beside three capped tracks, so the 600px scroll width gave it about 90px and names truncated to a few letters.

What changed

  • resources/views/filament/pages/custom-fields-management.blade.php (flat layout, sections disabled): the wrapper is flex-col below md and flex-row from md. The entity tabs render twice: a horizontal x-filament::tabs shown below md, and the existing vertical one shown from md. Both bind the same setCurrentEntityType click.
  • resources/views/livewire/manage-fields-table.blade.php: the name track is minmax(10rem,1fr) instead of 1fr in the header, active and archived rows.
  • resources/dist/custom-fields.css is rebuilt. It only gains the new utilities (239 bytes).

Why this way

Filament's tabs component takes vertical as a render-time prop, so one list cannot switch orientation by breakpoint without overriding Filament's .fi-tabs.fi-vertical CSS. Two lists with md:hidden / hidden md:block keep the change inside this package's own markup. The hidden list is display: none, so assistive technology meets only one.

The name floor keeps the existing 600px scroll width: the capped tracks fill their headroom first, and the name never drops below 160px. Relaticle currently patches both problems from its own theme with selectors on this package's markup. That workaround can go once this ships.

Behavior to know about

  • Desktop is unchanged: vertical tabs on the left, same table.
  • The sections layout (sections enabled) is untouched.
  • No config, no migration, no API change.

Tests

None added. This is a layout-only change and the package has no browser suite. Relaticle's tests/Browser/Workspaces/CustomFieldsBrowserTest.php covers the phone layout end to end.

Checked

On e4368fd8: Pint passes and the suite runs 1123 tests green (3 todos). I loaded these views into Relaticle with its theme workaround removed and measured the page in Chromium and WebKit:

Viewport Tabs Name column Page scrolls sideways
390px light horizontal, above the table 160px no
390px dark horizontal, above the table 160px no
1440px vertical, beside the table 394px no

Not checked

Rector and PHPStan run in CI. Switching entities by tapping a tab in the phone row was not clicked through; it uses the same wire:click as the desktop list.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan added this pull request to the merge queue Nov 6, 2026
Merged via the queue into 3.x with commit ed251be Nov 6, 2026
7 checks passed
@ManukMinasyan
ManukMinasyan deleted the fix/fields-settings-on-phones branch November 6, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants