Skip to content

ci: run pint and the changelog updater on php with mbstring - #305

Merged
ManukMinasyan merged 2 commits into
3.xfrom
fix/ci-php-86-mbstring
Nov 20, 2026
Merged

ManukMinasyan merged 2 commits into
3.xfrom
fix/ci-php-86-mbstring

Conversation

@ManukMinasyan

Copy link
Copy Markdown
Member

The Pint check and the release changelog job work again. Both broke on Nov 20 when the Docker images under their actions moved to PHP 8.6 without the mbstring extension. Pint failed on every push (Call to undefined function Termwind\ValueObjects\mb_strimwidth()), and the v3.18.5 release published without its CHANGELOG entry.

What changed

  • .github/workflows/pint.yml drops aglipanci/laravel-pint-action. It now sets up PHP 8.4 with mbstring through shivammathur/setup-php, runs composer update, then vendor/bin/pint. The auto-commit step is unchanged.
  • .github/workflows/release.yml moves stefanzweifel/changelog-updater-action from v1.12.0 to v1.13.3 (f7c43fed). Its maintainer pinned the image to php:8.5-cli-alpine in that release, and its inputs are the same.
  • CHANGELOG.md gets the v3.18.5 entry the failed job should have written, copied from the GitHub release notes in the action's format.

Why this way

The Pint action builds FROM composer:latest and installs Pint with composer global require and no version. Without mbstring, Composer resolved Pint v0.1.7, a 2022 release. The Nov 13 run had resolved v1.32.3. The action's last release was July 2025, and its PHP 8.6 issue (#28) has no reply, so a pin bump has nothing to move to. tests.yml and refactor.yml already install Pint this way, so all three workflows now resolve the same Pint.

The changelog action had a fixed release, so a pin bump was the smallest change there.

Behavior to know about

  • The Pint job now runs composer update first, so it takes longer than the Docker action did.
  • vendor/ and composer.lock are gitignored, so the auto-commit still commits style fixes only.
  • 4.x has its own copies of these workflows and is not changed here.

Checked

  • Pint, end to end: a throwaway branch ci/verify-pint-mbstring built on 9df571ac added a PHP file with style errors. Run 44831867115 passed. Pint reported 393 files, 1 style issue fixed, and the auto-commit pushed Fix styling touching only that file. The branch is deleted.
  • The changelog action's own CI (test) passes on f7c43fed.
  • actionlint is clean on pint.yml. On release.yml it reports two findings, both on lines this PR doesn't touch (the $/ reusable workflow reference and an unquoted $PRERELEASE_FLAG).

Not checked

  • The changelog job itself runs only on a tag push, so it is not exercised until the next release.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 22:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan added this pull request to the merge queue Nov 20, 2026
Merged via the queue into 3.x with commit 31292e9 Nov 20, 2026
9 checks passed
@ManukMinasyan
ManukMinasyan deleted the fix/ci-php-86-mbstring branch November 20, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants