Repository navigation
ci: run pint and the changelog updater on php with mbstring - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pint check and the release changelog job work again. Both broke on Nov 20 when the Docker images under their actions moved to PHP 8.6 without the
mbstringextension. Pint failed on every push (Call to undefined function Termwind\ValueObjects\mb_strimwidth()), and the v3.18.5 release published without its CHANGELOG entry.What changed
.github/workflows/pint.ymldropsaglipanci/laravel-pint-action. It now sets up PHP 8.4 withmbstringthroughshivammathur/setup-php, runscomposer update, thenvendor/bin/pint. The auto-commit step is unchanged..github/workflows/release.ymlmovesstefanzweifel/changelog-updater-actionfrom v1.12.0 to v1.13.3 (f7c43fed). Its maintainer pinned the image tophp:8.5-cli-alpinein that release, and its inputs are the same.CHANGELOG.mdgets the v3.18.5 entry the failed job should have written, copied from the GitHub release notes in the action's format.Why this way
The Pint action builds
FROM composer:latestand installs Pint withcomposer global requireand no version. Withoutmbstring, Composer resolved Pint v0.1.7, a 2022 release. The Nov 13 run had resolved v1.32.3. The action's last release was July 2025, and its PHP 8.6 issue (#28) has no reply, so a pin bump has nothing to move to.tests.ymlandrefactor.ymlalready install Pint this way, so all three workflows now resolve the same Pint.The changelog action had a fixed release, so a pin bump was the smallest change there.
Behavior to know about
composer updatefirst, so it takes longer than the Docker action did.vendor/andcomposer.lockare gitignored, so the auto-commit still commits style fixes only.4.xhas its own copies of these workflows and is not changed here.Checked
ci/verify-pint-mbstringbuilt on9df571acadded a PHP file with style errors. Run 44831867115 passed. Pint reported393 files, 1 style issue fixed, and the auto-commit pushedFix stylingtouching only that file. The branch is deleted.test) passes onf7c43fed.actionlintis clean onpint.yml. Onrelease.ymlit reports two findings, both on lines this PR doesn't touch (the$/reusable workflow reference and an unquoted$PRERELEASE_FLAG).Not checked