Skip to content

fix: clear the open security alerts and update dependencies - #226

Merged
ManukMinasyan merged 1 commit into
4.xfrom
chore/security-and-deps-2026-11-07
Nov 6, 2026
Merged

ManukMinasyan merged 1 commit into
4.xfrom
chore/security-and-deps-2026-11-07

Conversation

@ManukMinasyan

@ManukMinasyan ManukMinasyan commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

This clears every open security alert on Flowforge except one, and brings each dependency to its latest compatible version, before the next 4.x tag. Dependabot reports six npm alerts: two in the root package-lock.json (high: follow-redirects; medium: postcss-selector-parser) and four in the docs site (high: zod; medium: minimatch, glob; low: deepmerge). Code scanning reports one zizmor finding in release.yml. This PR fixes all of them except deepmerge, which has no patched release. There are no secret-scanning alerts.

None of these alerts reach the package itself. Composer users never install the npm dev tooling or the docs/ Nuxt site.

What changed

  • package-lock.json: updated within its ranges. follow-redirects moves to 1.16.2, which closes Dependabot #267. Playwright, which drives the browser suite, moves 1.64.1 to 1.65.0 and brings a new WebKit build.
  • package.json: drops @tailwindcss/typography. Its latest release (0.5.20) pins postcss-selector-parser to exactly 6.0.10, the only vulnerable copy (Dependabot #263). Nothing in the repository uses it: the build is bin/build.js (esbuild over two JS entries), and flowforge-modern.css ships as plain source through Css::make.
  • docs/package.json overrides, the same set custom-fields uses (Dependabot #245, #265, #266):
    • zod resolves to the site's own ^4.6.7 ($zod). @nuxt/content still requires zod 3, and zod 3 has no patched release.
    • minimatch resolves to ^11.0.5 (was 10.2.6, affected range 7.0.0 to 11.0.0).
    • glob resolves to ^14.0.4 (was 13.0.6, affected range 9.0.0 to 14.0.1).
  • docs/package-lock.json: regenerated with those overrides.
  • release.yml (code scanning #9): calls tests.yml through GitHub's self-repository syntax uses: $/.github/workflows/tests.yml, as custom-fields does since v3.17.0.
  • tests.yml: the "Actions pinned to SHA" check exempts $/ references as well as ./ ones, or it fails on release.yml.
  • zizmor.yml: zizmorcore/zizmor-action v0.8.0 to v0.8.1. Every other pinned action is already at its latest release.

Why this way

npm audit fix only offers semver-major downgrades of docus, nuxt and @nuxt/ui for the docs alerts. Overrides on the vulnerable leaves are the smallest fix that keeps the site on current versions. For the root alert, removing an unused plugin beats overriding a dependency it pins exactly.

Behavior to know about

  • Composer: no change to composer.json. A fresh composer update leaves no direct dependency outdated, and composer audit finds no advisories.
  • Built assets: npm run build regenerates resources/dist/flowforge.js and flowforge-modern.js byte for byte, so dist is unchanged.
  • deepmerge stays open: no patched release exists. It reaches the docs build only, through nitropack and docus.

Checked

On 3fdf029f4:

  • npm audit: 0 vulnerabilities at the root, and only the 9 low deepmerge findings (one alert plus its parents) in docs/.
  • The docs site builds with CI's env (NUXT_SITE_URL, NUXT_APP_BASE_URL): clean npm ci, then npm run generate prerenders 58 routes.
  • The pinned-actions assertion from tests.yml passes locally.

CI is green on 3fdf029f after one re-run. The first run failed a single WebKit test, "dragging sets the documented states" in ModernBoardTest: the card landed one slot off ([1,2,4,3] for [1,4,2,3]). On Playwright 1.65.0 locally that test passed 5 of 5, the whole WebKit browser suite passed 27 of 27 twice, and the re-run passed. The drag test is timing-sensitive, so watch for it on 4.x.

Not checked

The PHP suite and browser tests run in CI; this PR changes no PHP. The $/ release path is only exercised when a tag is pushed.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 23:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan merged commit ea62a1d into 4.x Nov 6, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants