Repository navigation
fix: clear the open security alerts and update dependencies - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clears every open security alert on Flowforge except one, and brings each dependency to its latest compatible version, before the next 4.x tag. Dependabot reports six npm alerts: two in the root
package-lock.json(high: follow-redirects; medium: postcss-selector-parser) and four in the docs site (high: zod; medium: minimatch, glob; low: deepmerge). Code scanning reports one zizmor finding inrelease.yml. This PR fixes all of them except deepmerge, which has no patched release. There are no secret-scanning alerts.None of these alerts reach the package itself. Composer users never install the npm dev tooling or the
docs/Nuxt site.What changed
package-lock.json: updated within its ranges. follow-redirects moves to 1.16.2, which closes Dependabot #267. Playwright, which drives the browser suite, moves 1.64.1 to 1.65.0 and brings a new WebKit build.package.json: drops@tailwindcss/typography. Its latest release (0.5.20) pinspostcss-selector-parserto exactly 6.0.10, the only vulnerable copy (Dependabot #263). Nothing in the repository uses it: the build isbin/build.js(esbuild over two JS entries), andflowforge-modern.cssships as plain source throughCss::make.docs/package.jsonoverrides, the same set custom-fields uses (Dependabot #245, #265, #266):zodresolves to the site's own^4.6.7($zod).@nuxt/contentstill requires zod 3, and zod 3 has no patched release.minimatchresolves to^11.0.5(was 10.2.6, affected range 7.0.0 to 11.0.0).globresolves to^14.0.4(was 13.0.6, affected range 9.0.0 to 14.0.1).docs/package-lock.json: regenerated with those overrides.release.yml(code scanning #9): callstests.ymlthrough GitHub's self-repository syntaxuses: $/.github/workflows/tests.yml, as custom-fields does since v3.17.0.tests.yml: the "Actions pinned to SHA" check exempts$/references as well as./ones, or it fails onrelease.yml.zizmor.yml:zizmorcore/zizmor-actionv0.8.0 to v0.8.1. Every other pinned action is already at its latest release.Why this way
npm audit fixonly offers semver-major downgrades of docus, nuxt and @nuxt/ui for the docs alerts. Overrides on the vulnerable leaves are the smallest fix that keeps the site on current versions. For the root alert, removing an unused plugin beats overriding a dependency it pins exactly.Behavior to know about
composer.json. A freshcomposer updateleaves no direct dependency outdated, andcomposer auditfinds no advisories.npm run buildregeneratesresources/dist/flowforge.jsandflowforge-modern.jsbyte for byte, sodistis unchanged.Checked
On
3fdf029f4:npm audit: 0 vulnerabilities at the root, and only the 9 low deepmerge findings (one alert plus its parents) indocs/.NUXT_SITE_URL,NUXT_APP_BASE_URL): cleannpm ci, thennpm run generateprerenders 58 routes.tests.ymlpasses locally.CI is green on
3fdf029fafter one re-run. The first run failed a single WebKit test, "dragging sets the documented states" inModernBoardTest: the card landed one slot off ([1,2,4,3]for[1,4,2,3]). On Playwright 1.65.0 locally that test passed 5 of 5, the whole WebKit browser suite passed 27 of 27 twice, and the re-run passed. The drag test is timing-sensitive, so watch for it on 4.x.Not checked
The PHP suite and browser tests run in CI; this PR changes no PHP. The
$/release path is only exercised when a tag is pushed.