Repository navigation
fix(modern): keep a column's scrollbar off its cards - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Safari on macOS, scrolling a Modern board column drew the scrollbar thumb flush against the cards' right edge, so it read as overlapping them.
What changed
.ff-cardsinresources/css/flowforge-modern.cssnow pads0.5rem 0.75reminstead of0.5rem. Cards are 4px narrower on each side and stay centred in the tray.Why
macOS overlay scrollbars take no layout space: they paint inside the scroll container's padding. The card border is a
box-shadowring drawn 1px outside the card, so at0.5remthe ring sat 7px from the scroll edge. The thumb in a production screenshot covered those same 7px (3px inset plus 4px wide). At0.75remthe ring sits 11px from the edge, which leaves a 4px gap.shadcn's ScrollArea follows the same rule: its overlay bar is 10px wide and its example content pads 16px, so content always clears the bar.
Only the inline padding changed. A thicker block padding would only add space above the first card and below the last.
Behavior to know about
0: its rule comes later at the same specificity..ff-cardspadding keeps it.Tests
tests/Browser/ModernBoardTest.php: "a card leaves room for an overlay scrollbar on both sides of its tray" checks that a card sits 12px from both inline edges of its column's scroll container.Checked
0.5rempadding.tests/Modern/Feature/DesignContractTest.php: 55 passed.Not checked
Playwright never paints macOS overlay scrollbars, so no automated run shows the thumb itself. The gap is proven by geometry. Seeing it needs a scroll in Safari on a column with enough cards to overflow.