Skip to content

fix(modern): keep a column's scrollbar off its cards - #227

Merged
ManukMinasyan merged 1 commit into
4.xfrom
fix/modern-cards-scrollbar-room
Nov 7, 2026
Merged

ManukMinasyan merged 1 commit into
4.xfrom
fix/modern-cards-scrollbar-room

Conversation

@ManukMinasyan

Copy link
Copy Markdown
Member

In Safari on macOS, scrolling a Modern board column drew the scrollbar thumb flush against the cards' right edge, so it read as overlapping them.

What changed

.ff-cards in resources/css/flowforge-modern.css now pads 0.5rem 0.75rem instead of 0.5rem. Cards are 4px narrower on each side and stay centred in the tray.

Why

macOS overlay scrollbars take no layout space: they paint inside the scroll container's padding. The card border is a box-shadow ring drawn 1px outside the card, so at 0.5rem the ring sat 7px from the scroll edge. The thumb in a production screenshot covered those same 7px (3px inset plus 4px wide). At 0.75rem the ring sits 11px from the edge, which leaves a 4px gap.

shadcn's ScrollArea follows the same rule: its overlay bar is 10px wide and its example content pads 16px, so content always clears the bar.

Only the inline padding changed. A thicker block padding would only add space above the first card and below the last.

Behavior to know about

  • Applies to Modern boards only. Classic boards are untouched.
  • A collapsed column still pads 0: its rule comes later at the same specificity.
  • Lane cells don't scroll on their own, so they are unchanged.
  • No new token, hook or state. An app that sets its own .ff-cards padding keeps it.

Tests

tests/Browser/ModernBoardTest.php: "a card leaves room for an overlay scrollbar on both sides of its tray" checks that a card sits 12px from both inline edges of its column's scroll container.

Checked

  • The new test passes in Chrome and Safari, and fails in Chrome with the old 0.5rem padding.
  • tests/Modern/Feature/DesignContractTest.php: 55 passed.
  • Pint passes on the test file.

Not checked

Playwright never paints macOS overlay scrollbars, so no automated run shows the thumb itself. The gap is proven by geometry. Seeing it needs a scroll in Safari on a column with enough cards to overflow.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan merged commit dc13647 into 4.x Nov 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants