Skip to content

test(columns): wait for the add column form to hide before reading it - #233

Merged
ManukMinasyan merged 1 commit into
4.xfrom
fix/webkit-add-column-wait
Nov 15, 2026
Merged

ManukMinasyan merged 1 commit into
4.xfrom
fix/webkit-add-column-wait

Conversation

@ManukMinasyan

Copy link
Copy Markdown
Member

The v4.4.0 release run deleted its tag after one WebKit browser test failed: clicking the add column tile, typing a name and pressing enter adds the column read the form's visibility the moment the new column rendered. WebKit applies x-show a frame later, so the read could land before the form hid. The same tree passed WebKit on #232.

The test now waits for the form to hide, as its siblings at lines 1383 and 1398 already do. No production change.

Checked: the test passes 3 of 3 in WebKit and 1 of 1 in Chromium locally (vendor/bin/pest tests/Browser/ModernBoardTest.php --filter='pressing enter adds the column' --browser safari). Not checked: the flake itself does not reproduce locally, so the fix rests on the timing above.

Copilot AI balanced review requested due to automatic review settings November 15, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManukMinasyan
ManukMinasyan merged commit 5c624e1 into 4.x Nov 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants