Repository navigation
test(columns): wait for the add column form to hide before reading it - #233
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v4.4.0 release run deleted its tag after one WebKit browser test failed:
clicking the add column tile, typing a name and pressing enter adds the columnread the form's visibility the moment the new column rendered. WebKit appliesx-showa frame later, so the read could land before the form hid. The same tree passed WebKit on #232.The test now waits for the form to hide, as its siblings at lines 1383 and 1398 already do. No production change.
Checked: the test passes 3 of 3 in WebKit and 1 of 1 in Chromium locally (
vendor/bin/pest tests/Browser/ModernBoardTest.php --filter='pressing enter adds the column' --browser safari). Not checked: the flake itself does not reproduce locally, so the fix rests on the timing above.