Skip to content

Add a macro for logging runtime - #2517

Merged
simonkrogmann merged 1 commit into
remindmodel:developfrom
simonkrogmann:runtime-macro
Nov 13, 2026
Merged

simonkrogmann merged 1 commit into
remindmodel:developfrom
simonkrogmann:runtime-macro

Conversation

@simonkrogmann

@simonkrogmann simonkrogmann commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Put runtime logging code into a macro to avoid repetitive code. Also update some outdated module names in error messages.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):


* satisfy dependencies
$ifi not %damages% == 'KotzWenz' abort "module internalizeDamages=KotzWenzItr requires module damages=KotzWenz";
$ifi not %damages% == 'KotzWenz' abort "module internalizeDamages=KotzWenzCPreg requires module damages=KotzWenz";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you rename the module or was it updated automatically and was wrong in the code?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong in the code. I assume when KotzWenzCPreg was created, code was copied there from KotzWenzItr and then edited. Updating this line was forgotten.

@simonkrogmann
simonkrogmann merged commit 8f768b9 into remindmodel:develop Nov 13, 2026
2 checks passed
@simonkrogmann
simonkrogmann deleted the runtime-macro branch November 13, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants