Repository navigation
Add a macro for logging runtime - #2517
Merged
Merged
Conversation
simonkrogmann
force-pushed
the
runtime-macro
branch
from
November 3, 2026 21:08
d8e72af to
f8af1cf
Compare
simonkrogmann
requested review from
dklein-pik
and removed request for
fschreyer
November 13, 2026 10:03
LaviniaBaumstark
approved these changes
Nov 13, 2026
|
|
||
| * satisfy dependencies | ||
| $ifi not %damages% == 'KotzWenz' abort "module internalizeDamages=KotzWenzItr requires module damages=KotzWenz"; | ||
| $ifi not %damages% == 'KotzWenz' abort "module internalizeDamages=KotzWenzCPreg requires module damages=KotzWenz"; |
Member
There was a problem hiding this comment.
did you rename the module or was it updated automatically and was wrong in the code?
Contributor
Author
There was a problem hiding this comment.
It was wrong in the code. I assume when KotzWenzCPreg was created, code was copied there from KotzWenzItr and then edited. Updating this line was forgotten.
simonkrogmann
force-pushed
the
runtime-macro
branch
from
November 13, 2026 14:50
f8af1cf to
e8a479f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Put runtime logging code into a macro to avoid repetitive code. Also update some outdated module names in error messages.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)