Skip to content

relax bioshare enforcement in q_shbiofe_up and q_shbiofe_lo - #2535

Merged
fbenke-pik merged 1 commit into
remindmodel:developfrom
fbenke-pik:hotfix
Nov 16, 2026
Merged

fbenke-pik merged 1 commit into
remindmodel:developfrom
fbenke-pik:hotfix

Conversation

@fbenke-pik

@fbenke-pik fbenke-pik commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Set back value to 2.5% as 2% still causes problems and requires further investigation (undoing parts of #2531).

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@fbenke-pik
fbenke-pik marked this pull request as ready for review November 16, 2026 09:18
@fbenke-pik
fbenke-pik merged commit 35822de into remindmodel:develop Nov 16, 2026
14 checks passed
@fbenke-pik
fbenke-pik deleted the hotfix branch November 16, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants