Repository navigation
Fix non-CO2 MACC price handling and emission accounting inconsistencies (audit results) - #2537
Open
simonkrogmann wants to merge 1 commit into
Open
simonkrogmann wants to merge 1 commit into
simonkrogmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Eight small, independent fixes in the emissions-related code: non-CO2 MAC (marginal
abatement cost curve) price lookup, air-pollutant emission factors, regional emission-cap
allocation, and unit documentation. None of them touches the default CO2 accounting path;
items 1, 2, 5 and 6 change results in the affected switches.
Changes
core/datainput.gms: removesm_dmac = 5override forPBL_2007MACCs.core/declarations.gmsalready setssm_dmac = 5 * sm_D2005_2_D2017(PBL_2007) and20 * s_D2010_2_D2017(PBL_2022) so that the MAC price step is in US$2017/tCeq.The later assignment in
datainput.gmsreset the PBL_2007 step to 5 US$2005/tCeq,so the deflator introduced in d7490b4 had no effect for that MACC version.
The default
PBL_2022path is unaffected.core/presolve.gms: use the AR4 methane GWP in the gas-price conversion for the CH4 MAC step.The MAC step for
ch4gas/ch4coalis driven by the maximum of the carbon price and thegas-price increase since 2005. The carbon price is rescaled with
25/s_gwpCH4so that itsits on the AR4-based price axis of the MACC data, but the gas price was converted to
US$/tCeq with the AR5 GWP (28). Both prices now use the same AR4 basis (
s_gwpCH4_AR4).Effect: the gas-price driven abatement step is about 12 % higher than before.
core/declarations.gms: correct unit description ofp_histEmiMacandp_histEmiSector.The input files (mrcommons
calcHistEmissions) are in Mt CO2, Mt CH4 and Mt N2O, andpresolve.gmsdivides the N2O values by 44/28 accordingly. The description said[GtC, Mt CH4, Mt N]. Documentation only.core/datainput.gms: fix units in thecm_altFeEmiFaccomments.The derived numbers 73.33 and 107.31 are MtCO2/EJ, not GtC/TWa, and the source values
are GtC/ZJ, not "zeta joule". Comment only.
modules/11_aerosols/exoGAINS2025/datainput.gms: global mean emission factor divided bycard(regi).p11_EF_meandivided the regional sum by a hard-coded 11. The default H12 mapping has12 regions and EU21 has 21, so the mean used in the pollution-cost calculation was
biased by
card(regi)/11.modules/41_emicapregi/AbilityToPay/datainput.gms:** 1/3replaced by**(1/3).In GAMS
**binds tighter than/, so the expression was a division by 3 instead ofthe cube root described in the comment and the parameter description. The factor 1/3
cancels in
p41_correct_factor, but the regional allocation was linear in relativeGDP per capita instead of cube-root.
modules/41_emicapregi/PerCapitaConvergence/datainput.gms: fix misspelledp41_shEmi20200.The symbol is not declared (
p41_shEmi2020is), so this realization did not compile.Unit and switch names in comments and descriptions.
p11_emiFacAPis Tg(species)/TWa as in the input-file header, not Gt; the bunkersubtraction comment in
core/postsolve.gmsreferred tocm_bunkerscenwhile the codeuses
c_budgetscen.Open question for reviewers (not changed in this PR)
The direction of the AR4 correction of the carbon price itself (
p_priceCO2forMAC * (25/28)for CH4,
(298/265)for N2O inpresolve.gms) looks inverted: REMIND values 1 t CH4 at28*(12/44) tC, while a MAC step at AR4 price p costs p25(12/44) US$/tCH4, so the lookup
price should be P*28/25. The correction is also applied only to the MAgPIE sectors and to
ch4gas/ch4coal, whilep_emi_quan_conv_ar4treats all CH4/N2O MAC sectors as AR4-based.This needs confirmation of how the MACC input data were built before changing it.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)