Skip to content

Fix inconsistencies in carbon-price and policy modules (21, 40, 45, 47, audit results) - #2538

Open
simonkrogmann wants to merge 1 commit into
remindmodel:developfrom
simonkrogmann:audit-policy
Open

simonkrogmann wants to merge 1 commit into
remindmodel:developfrom
simonkrogmann:audit-policy

Conversation

@simonkrogmann

@simonkrogmann simonkrogmann commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Seven small, independent fixes in the tax, techpol, carbon-price and regipol modules.
Items 1, 2 and 3 can change results for the respective switches; the remaining items are
documentation only. None of them affects a default run without the listed switches.

Changes

  1. modules/47_regipol/regiCarbonPrice/postsolve.gms: FE share targets use total FE in the denominator.
    For share-type FE targets (FE_wo_n_e, FE_wo_b_wo_n_e) the non-energy correction in the
    denominator used qttyTargetGroup instead of "all", unlike the two preceding denominator
    terms. The total therefore depended on the target group. Copy-paste from the numerator.
    Only relevant for share targets with a group other than all; none of the hard-coded
    scenarios use one.

  2. modules/21_tax/on/datainput.gms: cm_CO2TaxSectorMarkup accepts single regions.
    The mapping used regi_group, which only contains GLO and the *_regi groups. Single
    region codes such as EUR.trans 0.25 were silently ignored. The import-tax and SE-tax
    switches in the same file already use regi_groupExt, which includes the one-to-one mapping.

  3. modules/47_regipol/regiCarbonPrice/datainput.gms: consistent deflator in the initial ETS price path.
    The 20 US$2005/tCO2 start value is deflated to US$2017 but the 1 US$/tCO2/yr increment
    was not, while the analogous line for the 30 US$ path deflates both. Initialization only.

  4. modules/21_tax/on/postsolve.gms: add missing reference level p21_emiAllco2neg_acrossIterations0.
    presolve.gms and postsolve.gms are meant to contain the same reference-level block;
    this parameter was set in presolve only. It is only written, not read, so no result change.

  5. modules/45_carbonprice/functionalForm/datainput.gms: comments for cm_taxCO2_regiDiff = 2.
    The initialSpread20 branch said "spread equal to 10" and "ratio = 0.1" while the code
    uses a spread of 20 and a ratio of 0.05.

  6. modules/45_carbonprice/functionalForm/declarations.gms: s45_peakBudget is in GtCO2.
    It is assigned from pm_actualbudgetco2 (cumulative GtCO2); the description said GtC/yr.

  7. Comment cleanups. modules/21_tax/on/preloop.gms: subsidy cap is 0.2 T$/TWa, not $/TWa.
    modules/40_techpol/NDC/datainput.gms: removed a copied "million to billion people" comment
    on a line that copies a renewable share without rescaling.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant