Repository navigation
Fix inconsistencies in carbon-price and policy modules (21, 40, 45, 47, audit results) - #2538
Open
simonkrogmann wants to merge 1 commit into
Open
simonkrogmann wants to merge 1 commit into
simonkrogmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Seven small, independent fixes in the tax, techpol, carbon-price and regipol modules.
Items 1, 2 and 3 can change results for the respective switches; the remaining items are
documentation only. None of them affects a default run without the listed switches.
Changes
modules/47_regipol/regiCarbonPrice/postsolve.gms: FE share targets use total FE in the denominator.For share-type FE targets (
FE_wo_n_e,FE_wo_b_wo_n_e) the non-energy correction in thedenominator used
qttyTargetGroupinstead of"all", unlike the two preceding denominatorterms. The total therefore depended on the target group. Copy-paste from the numerator.
Only relevant for share targets with a group other than
all; none of the hard-codedscenarios use one.
modules/21_tax/on/datainput.gms:cm_CO2TaxSectorMarkupaccepts single regions.The mapping used
regi_group, which only containsGLOand the*_regigroups. Singleregion codes such as
EUR.trans 0.25were silently ignored. The import-tax and SE-taxswitches in the same file already use
regi_groupExt, which includes the one-to-one mapping.modules/47_regipol/regiCarbonPrice/datainput.gms: consistent deflator in the initial ETS price path.The 20 US$2005/tCO2 start value is deflated to US$2017 but the 1 US$/tCO2/yr increment
was not, while the analogous line for the 30 US$ path deflates both. Initialization only.
modules/21_tax/on/postsolve.gms: add missing reference levelp21_emiAllco2neg_acrossIterations0.presolve.gmsandpostsolve.gmsare meant to contain the same reference-level block;this parameter was set in presolve only. It is only written, not read, so no result change.
modules/45_carbonprice/functionalForm/datainput.gms: comments forcm_taxCO2_regiDiff = 2.The
initialSpread20branch said "spread equal to 10" and "ratio = 0.1" while the codeuses a spread of 20 and a ratio of 0.05.
modules/45_carbonprice/functionalForm/declarations.gms:s45_peakBudgetis in GtCO2.It is assigned from
pm_actualbudgetco2(cumulative GtCO2); the description said GtC/yr.Comment cleanups.
modules/21_tax/on/preloop.gms: subsidy cap is 0.2 T$/TWa, not $/TWa.modules/40_techpol/NDC/datainput.gms: removed a copied "million to billion people" commenton a line that copies a renewable share without rescaling.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)