Repository navigation
Audit PE and inital calibration (audit results) - #2540
Open
simonkrogmann wants to merge 1 commit into
Open
simonkrogmann wants to merge 1 commit into
simonkrogmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Seven small, independent fixes in trade, fossil, biomass, PE/FE parameter and initial-capacity
code. Items 1 to 3 change results slightly; the rest is documentation.
Changes
modules/24_trade/standard/bounds.gms: export redistribution in the initial year sums over the right regions.The extra exports that compensate the import corrections are distributed to regions
without a correction, proportional to their share in exports of "regions with no balance
problems". The denominator used
regiinstead ofregi2inside the sum, so it summedover all regions and the 2005 fixed trade was not globally balanced.
modules/31_fossil/grades2poly/bounds.gms: rent-discount clamp starts in the same year as the ramp.p31_rentdisctotramps linearly froms31_fuEx_startyr(2005) top31_rentdisc2overp31_rentconvyears, but the clamp top31_rentdisc2applied only after2010 + p31_rentconv.In between the factor overshot the target (oil with defaults: 0.97 in 2060, then 0.9 in 2065).
Commit f7692fc replaced
cm_startyearwiths31_fuEx_startyrin the ramp but left thehard-coded 2010 in the clamp.
modules/05_initialCap/on/preloop.gms: residue-capacity vintages use the same depreciation index asq_cap.p05_cap_resusedpm_omeg(regi,opTimeYr,te)without theopTimeYr+1shift and theopTimeYr.val ge 1guard thatq_capand every other replica of the pattern in this fileuse. The implied standing capacity of residue-using technologies, and hence
pm_pedem_res,was depreciated one year less than the model's own capacity equation. Effect is small.
modules/04_PE_FE_parameters/iea2014/declarations.gms: descriptions ofpm_fuExtrOwnConsandpm_histfegrowth.The first index of
pm_fuExtrOwnConsis the energy carrier consumed and the second theextracted fuel, the inverse of what the description said.
pm_histfegrowthis computedfrom 1995 to 2010 (exponent 1/15), not 1995 to 2005.
modules/31_fossil/grades2poly/datainput.gms: description off31_ffPolyCumEx.It was a copy of the
f31_ffPolyRentdescription; the parameter holds the minimum andmaximum cumulative extraction of the polynomial cost curves.
core/datainput.gms:p_histProdSeis read in TWh/yr.The description said TWa; the input-file header is TWh/year and the code divides by
sm_TWa_2_TWhdirectly afterwards.Comments aligned with code. Trade bounds: 2 % growth (not 1 %) and years 2010, 2015,
2020. Biomass production limit applies from
max(2010, cm_startyear), not 2035.Gas split comment: 85/15 as coded (
p04_shareNGTinGas = 0.15). Eta recalibration fadesout linearly until 2030, not 2025 or "next 15 years".
Open points (not changed here)
exports, the code uses 100 %, and the correction formula ignores import losses that the
trigger condition accounts for. Needs a decision on which side is intended.
unknown; the comment was aligned to the code.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)