Skip to content

fix(facade): report TradeHelperFacet sellAmount in token quanta #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshatmittal merged 1 commit into from
Oct 9, 2026
Merged

fix(facade): report TradeHelperFacet sellAmount in token quanta #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/facade/facets/TradeHelperFacet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ contract TradeHelperFacet {
address tradeAddress;
address sellToken;
address buyToken;
uint256 sellAmount;
uint256 bidAmount;
uint256 sellAmount; // {qSellTok}
uint256 bidAmount; // {qBuyTok}
}

function getAllOpenTradesForRToken(RTokenP1 rToken, uint48 timestamp)
Expand Down Expand Up @@ -75,7 +75,7 @@ contract TradeHelperFacet {
tradeAddress: address(trade),
sellToken: address(trade.sell()),
buyToken: address(trade.buy()),
sellAmount: trade.sellAmount(),
sellAmount: trade.lot(),
bidAmount: trade.bidAmount(timestamp == 0 ? uint48(block.timestamp) : timestamp)
});
}
Expand Down
Loading