Repository navigation
Deliver envelopes left in the inbound buffer before reading again - #203
Merged
Merged
Conversation
InboundConnection stops a batch after MaxBytesBeforeYield bytes and yields. On the next turn it read from the socket first whenever the buffer was below InflightBytes, even with complete envelopes still buffered. If the peer had nothing more to send, those envelopes waited forever: a large payload followed by a small message in the same read lost the small one. The connection now reads again only after it has popped every complete envelope.
…ound coroutine ends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliver envelopes left in the inbound buffer before reading again
InboundConnection stops a batch after MaxBytesBeforeYield bytes and yields.
On the next turn it read from the socket first whenever the buffer was below
InflightBytes, even with complete envelopes still buffered. If the peer had
nothing more to send, those envelopes waited forever: a large payload followed
by a small message in the same read lost the small one. The connection now
reads again only after it has popped every complete envelope.