Repository navigation
Conversation
resetius
force-pushed
the
read-buffer-uring
branch
from
November 15, 2026 21:46
620e1f8 to
af48349
Compare
resetius
force-pushed
the
read-buffer-iocp
branch
from
November 15, 2026 21:46
06f2ad8 to
465862f
Compare
resetius
force-pushed
the
read-buffer-uring
branch
from
November 15, 2026 22:15
af48349 to
fdd9b9b
Compare
resetius
force-pushed
the
read-buffer-iocp
branch
from
November 15, 2026 22:15
465862f to
0fd238a
Compare
resetius
force-pushed
the
read-buffer-uring
branch
from
November 15, 2026 22:25
fdd9b9b to
fa03c20
Compare
resetius
force-pushed
the
read-buffer-iocp
branch
from
November 15, 2026 22:25
0fd238a to
4b8e203
Compare
resetius
marked this pull request as ready for review
November 15, 2026 22:40
resetius
marked this pull request as draft
November 15, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #210 (stacked: the diff of this PR is the third commit only).
TIOCp reads ahead for
ReadBuffer()on sockets:PerSocketLimitqueued leases. The read-ahead operation is an ordinaryTOperation(its OVERLAPPED) inside a per-socket state held byunique_ptr, so it never moves.Poll()and in the wait ofCancel(op).WSA_OPERATION_ABORTED, asReadSome()does today. The state of a WSARecv in flight waits in a closing list until its packet comes.~TIOCpcancels the WSARecvs in flight (CancelIoEx) and waits for their packets before the memory goes away.ReadBuffer()throwsstd::errc::no_buffer_space, as on the readiness pollers (TUring waits instead, because its kernel picks from the ring).ReadSome()afterReadBuffer()takes from the same leases (the adapter of Read ahead on TUring with multishot reads into a buffer ring for ReadBuffer() #210).BufferedFiles = false), because WSARecv is for sockets only.Tests on Windows 10 (MSYS2 MINGW64, GCC 16.2, Debug), head 4b8e203:
test_read_buffer_*: 28/28 (TSelect, TPoll, TEPoll, TIOCp).