Repository navigation
Destroy the TNode drainer and connector before the buffers they use - #222
Merged
Merged
Conversation
Owner
Author
|
Independent review of head What I checked
Findings
|
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
TNodedeclaredSendBufferafterDrainer, so~TNodefreed the buffer before the suspended write was cancelled. On io_uring the kernel can read the freed memory until the cancel in~TAwaitablereturns.The fix is an explicit
~TNodethat destroysDrainerandConnectorfirst, so correctness does not depend on member declaration order. The destructor has a comment saying why. Member order is unchanged to keep the diff minimal.Test:
test_node_destroyed_during_blocked_writedestroys a node whose 64 MB write is blocked on a peer that never reads. It is meant to run under ASan; note that ASan cannot see kernel reads, so on io_uring it only exercises the teardown path rather than detecting the original race.