Repository navigation
Do not throw from TUring::Wait on EINTR - #224
Merged
Merged
Conversation
Treat -EINTR from io_uring_enter as a wake-up, like the epoll backend does, so signals (e.g. gdb attach) no longer kill the event loop.
Owner
Author
|
Independent review of head What I checked
Findings
|
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217
TUring::Wait()threw whenio_uring_enterreturned-EINTR, so any signal (e.g. a gdb attach) killed the event loop. Now-EINTRis treated as a wake-up, the same as in the epoll backend (which returns early on EINTR): completions and timers are processed and the caller loops. Other errors still throw.Test:
test_uring_wait_signalinterrupts a blockedWait({5,0})with SIGUSR1 (no SA_RESTART) from another thread. It throwsInterrupted system callwithout the fix and passes with it (rpi5, full ut_tests: 276 passed).