Repository navigation
Conversation
TActorContext::StartAsync() used Sender_.ActorId(), so the pending future of an async handler was stored in the sender's slot. With several actors serving one sender (scatter/gather) each AddPendingFuture overwrote the previous one and all but the last handler never finished. Use Self_.ActorId() and add a regression test with a boss and 4 workers whose async Receive sleeps before replying. Fixes #228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TActorContext::StartAsync()builtTAsyncwithSender_.ActorId(), so the pending future of an async handler (TBehavior::ReceivereturningTFuture<void>,ICoroActor::CoReceive) was attached to the sender's slot. With several actors serving one sender, eachAddPendingFutureoverwrote the previous future and all but the last handler never finished.The fix uses
Self_.ActorId().Test:
test_async_handler_scatter_gatherintests/test_actors.cpp(a boss sends work to 4 workers whose asyncReceivesleeps and then replies; all 4 replies must arrive). It fails on master in Release (1 != 4) and passes with the fix.Fixes #228