Repository navigation
Use one signature for all model constructors - #38
Merged
Merged
Conversation
main.c called two-parameter constructors through a three-parameter function pointer, which is undefined behaviour. All constructors now take struct EventProducer* (unused where not needed), so the table needs no casts. Also fixes the CreateGltf and CreatePoissonTest declarations in main.c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.ccalled two-parameter constructors (CreateTorus,CreateTriangle, ...) throughConstructorT, a three-parameter function pointer. Calling a function through an incompatible pointer type is undefined behaviour.Now every model constructor takes
(struct Render*, struct Config*, struct EventProducer*). The third parameter is ignored where it is not needed. The table inmain.chas no casts.Also fixed:
CreateGltfwas declared inmain.cwith two parameters but defined with three.CreateTriangle,CreateTorus) pass the event producer.Checks: clean build before and after has the same 5 warnings (none new);
ctestpasses (3/3). I did not run the Vulkan demos.