Skip to content

Free leaked pipelines in stl and poisson_test - #39

Merged
resetius merged 1 commit into
masterfrom
task/fix-leaks
Nov 19, 2026
Merged

resetius merged 1 commit into
masterfrom
task/fix-leaks

Conversation

@resetius

Copy link
Copy Markdown
Owner

The stl model never freed t->plt (the dot pipeline), and poisson_test never freed t->comp_poisson2. Both are now released with pl_free in the existing free functions, right after the other pipeline and before buffer_mgr_free, as the other models do.

Checked the other members of both structs: no other pipeline, buffer manager or malloc'ed member is leaked.

Testing: CI-style build (cmake -B build -G Ninja && cmake --build build) with and without the change, no new warnings; ctest passes (3/3). Also built with -fsanitize=address. The ASan leak check on Vulkan was not run; it needs the owner's agreement on run time.

Note: poisson_test calls exit(0) at the end of draw_, so its free function is not reached in that path; this PR does not change that.

stl: t->plt was never freed. poisson_test: t->comp_poisson2 was never freed.
@github-actions

Copy link
Copy Markdown

Test Results

9 tests  ±0   9 ✅ ±0   0s ⏱️ ±0s
3 suites ±0   0 💤 ±0 
3 files   ±0   0 ❌ ±0 

Results for commit e8ee0b7. ± Comparison against base commit 7278352.

@resetius
resetius merged commit ee1f5a3 into master Nov 19, 2026
2 checks passed
@resetius
resetius deleted the task/fix-leaks branch November 19, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant