Skip to content

ci(security-scan): let a CodeQL configuration error fail the job #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WomB0ComB0 merged 3 commits into from
Oct 1, 2026
Merged

ci(security-scan): let a CodeQL configuration error fail the job #69

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a49c556
ci(security-scan): let a CodeQL configuration error fail the job
WomB0ComB0 Sep 30, 2026
3f7596d
Merge branch 'main' into ci/codeql-analyze-fail-loud
WomB0ComB0 Oct 1, 2026
375d3b6
Merge branch 'main' into ci/codeql-analyze-fail-loud
WomB0ComB0 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/security-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,17 @@ jobs:
- name: Autobuild
uses: github/codeql-action/autobuild@1c5b675653bb5c22dbe9b12b556ec555138e09fd # v4.38.1
- name: Analyze
# Deliberately NOT continue-on-error. This step used to carry
# `continue-on-error: true` so the default-setup collision would not
# fail the job -- which turned "Analysis upload status is failed. /
# CodeQL job status was configuration error." into a permanent green
# check. Callers whose repositories have default setup enabled now omit
# `languages` instead of uploading an analysis that is discarded, so
# every failure left here is a real one -- extraction faults, autobuild
# breakage, a rejected SARIF -- and a real one must fail the job.
uses: github/codeql-action/analyze@1c5b675653bb5c22dbe9b12b556ec555138e09fd # v4.38.1
with:
category: "/language:${{ matrix.language }}"
continue-on-error: true # default-setup collision otherwise fails

# ── Gitleaks ──────────────────────────────────────────────────────────────
# The MIT gitleaks CLI, pinned by version and checksum — deliberately NOT
Expand Down
Loading