Repository navigation
chore: normalise the copyright holder to ResQ Systems, Inc. - #71
Merged
Merged
Conversation
The owner confirmed ResQ Systems, Inc. as the official entity name. A licence header is a company-and-classification statement, so it takes the company name rather than a product name. This repo was one of the non-conforming ones: 12 of its 13 stamped files carried "ResQ Software", and the single conforming file was dependabot.yml. A thirteenth, README.md line 69, carried a third variant. That last one is worth recording, because it is why this scan was done over whole files rather than headers. An earlier pass over the first few lines of each file found 13 stamped files and reported 12 needing change. README.md's copyright sits at line 69 and was invisible to it. Scanning only the top of a file is the same defect that let a duplicate licence header accumulate in the org's copyright tool, once per release, until it published six versions in a night. A header-only scan here would have left a third holder string in place and reported success. Note for whoever runs the org-wide pass: counting the most common holder per repo hides intra-repo divergence. Before this change this repository held three distinct holders across 17 copyright lines, and the modal one was wrong. Scope: the holder string only. Verified by execution -- every added and removed line in this diff is a Copyright line, zero SPDX lines are modified (they appear only as diff context), and actionlint is clean on all twelve changed workflows. Every copyright line in the repository now resolves to ResQ Systems, Inc.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner confirmed
ResQ Systems, Inc.as the official entity name. A licence header is a company-and-classification statement, so it takes the company name rather than a product name.This repository was one of the non-conforming ones.
ResQ Software.github/workflows/*.yml, line 1ResQREADME.mdline 69ResQ Systems, Inc.Why this was scanned over whole files
An earlier pass read the first few lines of each file. It found 13 stamped files and reported 12 needing change — and it was wrong, because
README.md's copyright sits at line 69 and was invisible to it.That is the same defect that let a duplicate licence header accumulate in the org's
copyrighttool: itshas_headercheck looked only at the top of a file, so a header pushed below the window became undetectable and a second one was prepended, once per release, until it published six versions in a night. Here the same shape would have left a third holder string in place and reported success.So the enumeration behind this PR is
git grepover every tracked file, with no line limit.One thing for whoever runs the org-wide pass
Counting the most common holder per repo hides intra-repo divergence. Before this change this repository held three distinct holders across 17 copyright lines, and the modal one was the wrong one. A census that reports one holder per repository will understate how much needs changing, and will point at the wrong target where the plurality is wrong — which, org-wide, it is:
ResQis the most-stamped string and is not the entity name.Scope and verification
The holder string only. Verified by execution rather than inspection:
Copyrightline — 0 non-Copyright changes.actionlintclean on all twelve changed workflows.ResQ Systems, Inc., re-checked over whole files after the edit.No workflow logic, no SPDX identifier, and no other content is touched.