Skip to content

fix: canvas with zero spark line rendering with area under it in KPI component - #10038

Merged
AdityaHegde merged 1 commit into
mainfrom
fix/canvas-zero-kpi-spark
Oct 21, 2026
Merged

AdityaHegde merged 1 commit into
mainfrom
fix/canvas-zero-kpi-spark

Conversation

@AdityaHegde

Copy link
Copy Markdown
Collaborator

When all the data is 0 (usually from a security policy) we will get a flat spark like. But it renders in the middle making the user think there is some data.
Screenshot 2026-10-20 at 9 17 42 AM

Updating to reuse yScale calculation method from explore so that the line bottoms out.
Screenshot 2026-10-20 at 9 19 02 AM

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde
AdityaHegde merged commit de14a79 into main Oct 21, 2026
19 of 20 checks passed
@AdityaHegde
AdityaHegde deleted the fix/canvas-zero-kpi-spark branch October 21, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants