Skip to content

feat: say "Convert to Vega-Lite" and create custom viz under viz/ - #10044

Merged
nishantmonu51 merged 2 commits into
mainfrom
nishant/custom-viz-convert-and-viz-folder
Oct 21, 2026
Merged

nishantmonu51 merged 2 commits into
mainfrom
nishant/custom-viz-convert-and-viz-folder

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator

User feedback on custom components (#9850), applied before 0.91 ships either convention:

  • The component editor action, tooltip, confirmation and notifications say Convert to Vega-Lite instead of "Eject to Vega-Lite" (en + es). Message keys and code identifiers keep the internal "eject" name.
  • New custom viz files are created under viz/ instead of viz_library/. The folder is only a convention for new files; the parser keys on type: component, so existing viz_library/ projects keep working.
  • Docs and the AI developer instructions use the new term and folder. PR docs: custom viz chart types, customization and converting to Vega-Lite #10029 carries a matching commit for the restructured docs.

Intended for cherry-pick into release-0.91.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

User feedback on the custom components feature (#9850), applied before 0.91 ships either convention:

- The component editor action and its tooltip, confirmation, progress and result notifications now say "Convert to Vega-Lite" instead of "Eject to Vega-Lite" (en + es). Message keys and code identifiers keep the internal "eject" name.
- New custom viz files are created under `viz/` instead of `viz_library/`. The folder is only a convention for new files; the parser keys on `type: component`, so existing `viz_library/` projects keep working.
- Docs and the AI developer instructions use the new term and folder.
@nishantmonu51
nishantmonu51 merged commit 7f8794e into main Oct 21, 2026
12 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/custom-viz-convert-and-viz-folder branch October 21, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants