Repository navigation
feat: resolve chat title references so that is human readable - #10047
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Malformed saved references can break conversation-list rendering, and some legacy truncated tags remain visible.
2 open issues
What changed in this PR
Makes chat titles human-readable by preserving references in the backend and resolving their labels in the frontend.
Changes:
- Truncates titles without splitting references or Unicode characters.
- Resolves reference labels in sidebar headers and conversation history.
- Adds backend truncation and frontend formatting tests.
| File | Description |
|---|---|
| web-common/src/features/chat/layouts/sidebar/SidebarHeader.svelte | Resolves header titles and supplies metadata to history. |
| web-common/src/features/chat/layouts/sidebar/ConversationHistoryMenu.svelte | Passes metadata to history entries. |
| web-common/src/features/chat/layouts/sidebar/ConversationHistoryItem.svelte | Formats history titles. |
| web-common/src/features/chat/layouts/fullpage/ConversationSidebar.svelte | Formats conversation titles and tooltips. |
| web-common/src/features/chat/core/context/conversation-title.ts | Adds reference-to-label formatting. |
| web-common/src/features/chat/core/context/conversation-title.spec.ts | Tests title formatting and fallbacks. |
| runtime/ai/router_agent.go | Preserves references during title truncation. |
| runtime/ai/router_agent_internal_test.go | Tests Unicode and reference-aware truncation. |
Review effort: Balanced
AdityaHegde
force-pushed
the
feat/resolved-chat-title-refs
branch
from
October 21, 2026 13:40
ba1ca00 to
abb0fbd
Compare
AdityaHegde
added a commit
that referenced
this pull request
Oct 21, 2026
* feat: resolve chat title references so that is human readable * PR review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References to measures/dimensions/metrics views etc show up as
<chat-reference>type="metricsView" metricsView="adbids"</chat-reference>. When the title is truncated it can be unreadable since it doesnt get resolved.promptToTitlein backend moves the cut point if it falls within achat-referenceblock. Also counts a block as 10 chars so that resolved title has somewhat consistent title length.chat-referenceblock wherever title is rendered.Checklist: