Repository navigation
fix: re-parsing an unchanged connector no longer restarts everything downstream - #10048
Merged
Merged
Conversation
…downstream analyzeTemplatedProperties built a connector's TemplatedProperties by ranging over a map, so a connector with two or more templated properties got them in a random order on every parse. The project parser compares specs with proto.Equal, which is order-sensitive for lists, so a full re-parse of an unchanged connector could update its spec. That marks every resource downstream of the connector as pending and cancels the running ones. Sort the property names so the parser output is stable.
k-anshul
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyzeTemplatedPropertiesbuilt a connector'sTemplatedPropertiesby ranging over a Go map. A connector with two or more templated properties (for exampledsnandwrite_dsn) got them in a random order on every parse.proto.Equal, which is order-sensitive for repeated fields. So a full re-parse of an unchanged connector file could update its spec, which marks every resource downstream of the connector as pending and cancels the running ones. Long model runs restarted from scratch, and a manual full refresh that takes longer than the gap between parses could never finish.Steps to reproduce:
dsn: "{{ .env.dsn }}"andwrite_dsn: "{{ .env.write_dsn }}", plus a model on that connector that takes a few minutes to run.rill project refresh --parsera few times.Checklist: