Skip to content

fix: cancelled full refresh discards processed partitions on retry - #10050

Merged
k-anshul merged 1 commit into
mainfrom
anshul/resume-cancelled-full-refresh
Oct 21, 2026
Merged

k-anshul merged 1 commit into
mainfrom
anshul/resume-cancelled-full-refresh

Conversation

@k-anshul

@k-anshul k-anshul commented Oct 21, 2026 •

Copy link
Copy Markdown
Member
  • A cancelled reconcile (e.g. a parent model being scheduled) returns before trigger flags are reset, so TriggerFull survived and the retry reset the model, dropping all processed partitions.
  • Once the first partition of a full refresh commits, TriggerFull is now replaced with Trigger, so a cancelled reconcile resumes pending partitions incrementally.
  • Follow-up to fix: during full reload if error occurs, processed partitions are dropped #8405, which persists model state after the first partition but didn't cover cancellation.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

Once the first partition of a full refresh commits, replace `TriggerFull` with `Trigger`,
so a cancelled reconcile resumes pending partitions incrementally instead of resetting again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@nishantmonu51 nishantmonu51 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k-anshul
k-anshul merged commit 6f05346 into main Oct 21, 2026
15 of 16 checks passed
@k-anshul
k-anshul deleted the anshul/resume-cancelled-full-refresh branch October 21, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants