Repository navigation
feat: embedded alerts/reports - #9972
Draft
AdityaHegde wants to merge 11 commits into
Draft
AdityaHegde wants to merge 11 commits into
AdityaHegde wants to merge 11 commits into
Conversation
AdityaHegde
force-pushed
the
feat/embedded-alerts-reports
branch
from
October 2, 2026 06:35
ecf301e to
875a721
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for alert and report for embedded users.
Changes needed by user,
GetIframerequest needsuser_emailpassed to enable alert/report.alert&reportfeature flags need to be enabled inrill.yaml(These have been changed to{{ not .user.embed }}so that it is opt-in)navigation: trueis not mandatory, but with it 2 icons are added top right for going to alerts/reports page and to open the dialog.navigateembed API is added to control the page from outside.Openbutton from email works.Technical details
embed_auth_tokensimilar to service token to grant temporary access to cloud. This only has access to manage alert/report.embed_auth_tokento make alert/report calls.embed_auth_tokencan either create or edit/delete own alert/report.TODO: Figure out how
Openfrom emails work. Open embedder's page with some params? Or is the current implementation enough?Checklist: