Conversation
luhenry
added a commit
that referenced
this pull request
Sep 24, 2026
Contributor
|
pytest /project/test puts /project on sys.path (test/ is a package), so
`import clang_tidy` resolved to the source tree, which has no data/bin/,
instead of the installed wheel. Mirror upstream's own release.yml, which
sets CIBW_BEFORE_TEST: rm -rf {package}/clang_tidy for this reason.
After a green 12h build, 6 of 7 tests passed and test_include_iostream
failed with "'iostream' file not found". The -v include search list
holds only clang's resource dir, /usr/local/include and /usr/include:
clang found no GCC installation. The manylinux_2_39_riscv64 image's
compiler is the system GCC 14.3.1 under /usr/lib/gcc/riscv64-redhat-linux,
and clang 22's RISCV64Triples list ("riscv64-unknown-linux-gnu",
"riscv64-unknown-elf", plus the vendorless "riscv64-linux-gnu") has no
redhat entry, unlike x86_64/aarch64. Debian/Ubuntu riscv64 hosts are
found through "riscv64-linux-gnu", so this is the test container, not
the wheel.
Upstream never runs this test in a Linux container either: its
release.yml sets CIBW_TEST_SKIP: "*linux*", and the test itself is
skipif(CI and linux) for ssciwr/clang-tidy-wheel#30, with CI=1 set
in the Dockerfile upstream tests Linux wheels in (f04a633). Setting
CI=1 in CIBW_TEST_ENVIRONMENT lets that marker fire and keeps the
other six tests, including test_main's real clang-tidy run.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-tidy22.1.8Compiles
clang-tidyandclang-apply-replacementsfrom LLVM 22.1.8 source via a CMakeExternalProject_add(same shape asbuild-clang-format.yml/build-libclang.yml). Upstream publishes no riscv64 wheel.Mirrors upstream's
release.yml.Differs from upstream
0dc6a6e, not av22.1.8tag - upstream has not cut that release yet.Matrix: cp312 only -
wheel.py-api = "py2.py3", so one interpreter build serves every version.Testing
License: OK