grpcio-observability: Add version 1.83.1 - #2422
Merged
Merged
Conversation
grpc's shared tests/__init__.py unconditionally imports tests/_loader.py, which imports coverage even for a plain pytest run, so the observability tests failed to collect with ModuleNotFoundError. Add coverage to CIBW_TEST_REQUIRES (matching upstream's own requirements.txt pin) and scope CIBW_TEST_ENVIRONMENT's PIP_ONLY_BINARY to grpcio instead of :all: so coverage's sdist-only riscv64 install isn't blocked (gotcha 488).
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpcio-observability1.83.1Compiles gRPC Python's OpenTelemetry observability plugin (
grpc_observability._cyobservability, Cython over vendored C++ call-tracer/metadata-exchange sources). Upstream publishes no riscv64 wheel.Mirrors this repo's
build-grpcio-tools.yml- samegrpc/grpcsource tree, same cibuildwheel/ccache/GRPC_PYTHON_BUILD_WITH_CYTHONpattern; upstream builds these internally via Bazel/Kokoro, not a public GH Actions workflow.Differs from upstream
package-dir: src/python/grpcio_observability, since the package lives nested in the monorepo rather than at its root like grpcio.src/python/grpcio_observability/make_grpcio_observability.pybefore the build - stages thegrpc_root/third_partysources upstream's owninstall_all_python_modules.shalso depends on, with the bazel-query step it also attempts failing non-fatally (falls back to the deps list already committed for this tag).Matrix: cp312/cp313/cp314 only, same as
build-grpcio.yml/build-grpcio-tools.yml- grpcio-observability sharespython_version.py's supported range and declares no free-threaded support.Testing
_open_telemetry_observability_test.pyand_observability_plugin_test.pyfrom upstream's owntests/observabilitysuite, matching theirBUILD.bazeldeps (grpcio, grpc_observability, opentelemetry-sdk)_csm_observability_plugin_test.py/_observability_api_test.pyfrom the same directory - both needgrpcio_csm_observability, not ported hereLicense: OK