chore: move the tests to the v1 jobs and kv apis - #238
Merged
Conversation
jobs/v1 protos with HeaderValue, Empty replies and Stat in place of GetStats; kv/v1 protos with Request, Item and RFC3339 expiry strings in place of the duration TTLs. On jobs v6.0.0-beta.9, kv v6.0.0-beta.7, informer v6.0.0-beta.4, resetter v6.0.0-beta.5 and http v6.0.0-beta.9, which carry the revert. kv-order.php routes php notices to stderr like the other workers; the deprecation warnings the old protobuf lib emits on 8.5 corrupted the goridge handshake on stdout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 75.48% 75.48%
=======================================
Files 6 6
Lines 518 518
=======================================
Hits 391 391
Misses 94 94
Partials 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobs/v1 protos (
HeaderValue,Emptyreplies,Stat), kv/v1 protos (Request/Item, RFC3339 expiry strings instead of duration TTLs), on the freshly tagged jobs v6.0.0-beta.9, kv v6.0.0-beta.7, informer v6.0.0-beta.4, resetter v6.0.0-beta.5 and http v6.0.0-beta.9.Also:
kv-order.phpnow routes php notices to stderr like the other workers - the deprecation warnings the old protobuf lib emits on PHP 8.5 corrupted the goridge handshake on stdout. Full suite green locally.