fix: back to status/v1 DTOs - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the status RPC layer back to using the status/v1 request/response DTOs (a rename-only change intended to restore compatibility with the previously released v1 wire format and ecosystem clients).
Changes:
- Switch status RPC server methods and tests from
api-go/status/v2DTOs back toapi-go/status/v1DTOs. - Bump
github.com/roadrunner-server/api-go/v6dependency fromv6.0.0-beta.13tov6.0.0-beta.14. - Temporarily pin test dependencies (
http/v6,jobs/v6) to pseudo-versions for sibling revert branches.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
rpc.go |
Updates RPC method signatures to use status/v1 Request/Response DTOs. |
tests/plugin_test.go |
Updates RPC client calls and imports to use status/v1 DTOs. |
go.mod |
Bumps api-go/v6 to v6.0.0-beta.14. |
go.sum |
Updates sums for the api-go/v6 version bump. |
tests/go.mod |
Bumps api-go/v6 and pins http/v6 + jobs/v6 to pseudo-versions for tests. |
tests/go.sum |
Updates sums for the test module dependency changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 92.30% 96.42% +4.12%
==========================================
Files 6 6
Lines 364 364
==========================================
+ Hits 336 351 +15
+ Misses 16 8 -8
+ Partials 12 5 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC layer back on status/v1 Request/Response (pure rename, wire format unchanged).
Part of the v1 proto revert (roadrunner-server/api#77, roadrunner-server/api-go#35): wire format back to what roadrunner-api-dto v1.14.1 and the released PHP packages speak. Pins api-go v6.0.0-beta.14. Tests temporarily pin sibling revert branches via pseudo-versions; they will be bumped to the new betas once tagged.