Skip to content

Fix reference cycles in VST3/CLAP wrappers #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estroBiologist wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix reference cycles in VST3/CLAP wrappers #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1668680
Attempt to fix memory leak in VST3 wrapper
estroBiologist Jul 11, 2025
cecab31
Fix memory leak in CLAP wrapper
estroBiologist Jul 11, 2025
dc2acb6
hack in wgpu feature
estroBiologist Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
199 changes: 185 additions & 14 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions nih_plug_egui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ default = ["opengl", "default_fonts"]
# `nih_plug_egui` always uses OpenGL since egui's wgpu backend is still unstable
# depending on the platform
opengl = ["egui-baseview/opengl"]
wgpu = ["egui-baseview/wgpu"]

default_fonts = ["egui-baseview/default_fonts"]
rayon = ["egui-baseview/rayon"]

Expand Down
2 changes: 1 addition & 1 deletion nih_plug_egui/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use serde::{Deserialize, Serialize};
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Arc;

#[cfg(not(feature = "opengl"))]
#[cfg(all(not(feature = "opengl"), not(feature = "wgpu")))]
compile_error!("There's currently no software rendering support for egui");

/// Re-export for convenience.
Expand Down
16 changes: 10 additions & 6 deletions src/wrapper/clap/wrapper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,19 +702,23 @@ impl<P: ClapPlugin> Wrapper<P> {
.lock()
.editor(AsyncExecutor {
execute_background: Arc::new({
let wrapper = wrapper.clone();
let wrapper = Arc::downgrade(&wrapper);

move |task| {
let task_posted = wrapper.schedule_background(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
if let Some(wrapper) = wrapper.upgrade() {
let task_posted = wrapper.schedule_background(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
}
}
}),
execute_gui: Arc::new({
let wrapper = wrapper.clone();
let wrapper = Arc::downgrade(&wrapper);

move |task| {
let task_posted = wrapper.schedule_gui(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
if let Some(wrapper) = wrapper.upgrade() {
let task_posted = wrapper.schedule_gui(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
}
}
}),
})
Expand Down
16 changes: 10 additions & 6 deletions src/wrapper/vst3/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,19 +332,23 @@ impl<P: Vst3Plugin> WrapperInner<P> {
.lock()
.editor(AsyncExecutor {
execute_background: Arc::new({
let wrapper = wrapper.clone();
let wrapper = Arc::downgrade(&wrapper);

move |task| {
let task_posted = wrapper.schedule_background(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
if let Some(wrapper) = wrapper.upgrade() {
let task_posted = wrapper.schedule_background(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
}
}
}),
execute_gui: Arc::new({
let wrapper = wrapper.clone();
let wrapper = Arc::downgrade(&wrapper);

move |task| {
let task_posted = wrapper.schedule_gui(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
if let Some(wrapper) = wrapper.upgrade() {
let task_posted = wrapper.schedule_gui(Task::PluginTask(task));
nih_debug_assert!(task_posted, "The task queue is full, dropping task...");
}
}
}),
})
Expand Down