Conversation
VST3 has no output-side equivalent of the input parameter change queue: data.output_param_changes is never touched. Add an AtomicRefCell<VecDeque> queue on WrapperInner, mirroring the existing output_events note queue and its guard on WrapperProcessContext, and drain it once per processing block into the host's IParameterChanges via add_parameter_data()/add_point(). Nothing feeds this queue yet, so it stays empty for now.
Add a realtime-safe way for a plugin to report a parameter value change from inside Plugin::process(), similar to ParamSetter::set_parameter() but without going through main-thread host automation and its locks. - CLAP reuses the existing OutputParamEvent::SetValue queue already used by GuiContext (no begin/end gesture, since this isn't a user gesture). - VST3 pushes onto the output parameter queue added in the previous commit. - Standalone forwards directly to the existing realtime-safe Wrapper::set_parameter queue, matching its GuiContext implementation. The parameter's reported value is not updated until the queued change is flushed to the host at the end of the current processing block.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should superscede: d790ee5
Adds a realtime-safe way for a plugin to report a parameter value change from inside Plugin::process(). (TODO in src/context/process.rs). Works like ParamSetter::set_parameter(), but skips main-thread host automation and its locks. The change is queued and flushed to the host at the end of the current processing block instead.