Repository navigation
fix stack effects of make_function, build_slice, and format_value ope… - #192
Merged
Merged
Conversation
Owner
|
Thanks. (The CI failures are due to not updating released Python versions.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected some operands in
xstack_effect()that existing tests don't cover. I also put in some links to the relevant Cpython code.MAKE_FUNCTIONreturnedNonefor flags 11–15 on 3.6–3.10 (3.10), and for flags 3–15 on 3.11 and 3.12 (3.11, 3.12).BUILD_SLICE(3.0–3.13) returned -1 for three-part slices like a[1:10:2] when it should be -2. (3.6, 3.13)FORMAT_VALUE(3.6–3.12) returned 0 when a format spec is present when it should be -1. (3.6, 3.12)I also added
test_stack_effect_operand_dependent, which checks these operands for all three opcodes.