Skip to content

Release v1.1.15 - #82

Open
roeai-release-bot[bot] wants to merge 1 commit into
mainfrom
release-sdk-python-1-0-99
Open

roeai-release-bot[bot] wants to merge 1 commit into
mainfrom
release-sdk-python-1-0-99

Conversation

@roeai-release-bot

@roeai-release-bot roeai-release-bot Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR updates the Python SDK for release 1.1.15.

Generated from:

  • roe-main release branch 1-0-99
  • roe-main commit a3884f3a93d9f38bfdc9cb42dc9b47790c5e0b25

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 3/5

[High risk] Adds new API endpoints and generated SDK code for skill sets.

The PR is not safe to merge until cancellation targets the correct run and skill-set calls use the configured organization by default.

Fix All in Claude CodeFindings

  1. P1 Cancellation targets wrong resource ▶
  2. P1 Skill-set requests omit organization ▶
  3. P2 Version example uses invalid files ▶

Summary

This release adds skill-set management, versioning, and generation operations to the Python SDK, alongside connection metadata updates and the 1.1.15 version bump.

  • The cancellation wrapper reverses two path identifiers.
  • Skill-set calls do not use the client’s configured organization by default.
  • The version-creation example shows an invalid file payload.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  C[RoeClient] --> S[SkillSetsAPI]
  W[wrappers.yml] --> S
  S --> H[Shared request helper]
  H --> E[Generated skill-set endpoints]
  E --> API[Roe API]
Loading

Reviews (1) · Last reviewed commit: "Release v1.1.15"

Comment thread openapi/wrappers.yml
Comment on lines +1290 to +1297
- name: run_id
location: path
wire_name: run_id
annotation: str
- name: skill_set_id
location: path
wire_name: skill_set_id
annotation: str

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Cancellation targets wrong resource
When a caller cancels a valid generation, the wrapper passes run_id before skill_set_id, but the generated endpoint expects the reverse. It requests /v1/skills/{run_id}/generation/{skill_set_id}/, so the server returns 404 and the run remains tracked. Reorder the path parameters in the wrapper contract so regeneration keeps the fix.

Suggested change
- name: run_id
location: path
wire_name: run_id
annotation: str
- name: skill_set_id
location: path
wire_name: skill_set_id
annotation: str
- name: skill_set_id
location: path
wire_name: skill_set_id
annotation: str
- name: run_id
location: path
wire_name: run_id
annotation: str

Knowledge Base Used: Wrapper generation

Fix in Claude Code

Comment thread openapi/wrappers.yml
Comment on lines +1104 to +1109
- name: organization_id
location: query
wire_name: organization_id
annotation: str | None
default: null
pass_unset_when_none: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Skill-set requests omit organization
When callers use the documented default for organization_id, skill-set methods send no organization ID in the query or body, even though the client already requires one in its configuration. The skill-set contract says this ID is needed for access control, so ordinary calls such as client.skill_sets.list() can fail organization scoping unless callers supply it again. Use the configured organization by default, as the existing resource wrappers do.

Knowledge Base Used:

Fix in Claude Code

Comment thread SDK_EXAMPLES.md

result = client.skill_sets.create_version(
skill_set_id="skill_set_id", # required
files=["value"], # required

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version example uses invalid files
The copy-ready create_version example passes files=["value"], but each file must be an object containing relative_path and content. Copying the example produces an invalid request instead of demonstrating version creation.

Suggested change
files=["value"], # required
files=[{"relative_path": "SKILL.md", "content": "# Example skill"}], # required

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants