Repository navigation
fix(login): tell the user when the device has no network - #299
Merged
BrandonKowalski merged 2 commits intoOct 18, 2026
Merged
Conversation
Connecting with Wi-Fi off fails with ENETUNREACH ("connect: network is
unreachable"). ClassifyError did not recognise it, so the login screen
showed "Something unexpected happened! Check the logs for more info."
even though nothing was wrong with the host.
Map ENETUNREACH to a new ErrNetworkUnreachable sentinel and
FailureNetwork, shown on the login and startup screens as "No network
connection! Please check that Wi-Fi is on and connected." EHOSTUNREACH
("no route to host") now counts as a refused connection instead of an
unknown error.
Adds the English and Spanish strings and tests for the dial failures.
Contributor
|
BrandonKowalski
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Logging in with Wi-Fi off showed "Something unexpected happened! Check the logs for more info." The log had the real cause:
ClassifyErrorknew refused connections, timeouts and DNS failures, but notENETUNREACH, so it fell through toFailureUnknown.Change
romm.ErrNetworkUnreachableforENETUNREACH, classified as the newauth.FailureNetwork.EHOSTUNREACH("no route to host") now counts as a refused connection instead of an unknown error, so it gets the existing "Could not connect to host" message.Testing
romm/errors_classify_test.gobuilds the dial errors net/http returns (wrapped the wayromm/auth.gowraps them) and checks each maps to the right sentinel. A case inTestClassifycoversFailureNetwork.go test ./...,go vet ./...andgo run ./tools/archcheckpass.goi18n mergedoes not list the new keys as missing fores.