Repository navigation
ci(release): move the major tag only to an immutable release - #26
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec and outcome
vX.Y.Ztag, but the repository setting was off, so the claim was not true andrelease.ymlonly printed the flag. Release immutability is now enabled on the repository (GET /repos/rootform-dev/action/immutable-releasesreturnsenabled: true).vX.Y.Z,release.ymlwaits up to about 75 seconds for GitHub to report the release immutable and fails before moving the major tag otherwise, with the recovery in the error. ADR-007 and CONTRIBUTING state the rule.Done when and evidence
qualitypasses on this head; the loop accepts a release that becomes immutable and fails one that stays mutable.OK after 2 refetches(rc 0) when the flag turns true,v1.0.0 is published but not immutable(rc 1) when it never does.bun run check:foundation(154 paths),bun run check:format,actionlint .github/workflows/release.ymlpass.bun run verifyruns inquality.Risk and privacy
DELETE /repos/rootform-dev/action/immutable-releases(only future releases are affected).Review checklist