Repository navigation
feat(dialects): present Google Cloud resources with official product icons - #28
Merged
Merged
Conversation
…icons The Google Cloud presentation catalog maps 197 of 217 Rules and 58 of 70 Concepts to google/* identities: a core product shows its own icon and any other product the icon of its category, as the Google Cloud product icon guide assigns them. Rules whose product has no icon in the library, such as the Google Cloud project, keep a neutral symbol. The Playground presentation files and their digests follow the new catalog, and the AWS icon evidence records the move to AWS Icons for PlantUML v23.1.
- Cloud Source Repositories draws the Developer Tools category icon, so 198 of 217 Google Cloud Rules name a google/* identity. - The Playground presentation files and their digests follow the catalog. - The changelog names the neutral symbol kept by products without an icon. - Drop the icon research notes this branch added under dialects/evidence; the catalog and the changelog describe the mapping.
Contributor
Contribution progressSource: Selected validations:
Applicable consumers are synchronized on their development branches and the staging sites. Releases are published from main; the Release row follows them. |
Contributor
Author
|
/rootform retry |
Contributor
Author
|
/rootform retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The Google Cloud Dialect now presents Google Cloud resources with the official Google Cloud product icons. Its presentation catalog maps 198 of 217 Rules and 58 of 70 Concepts to
google/*identities: a core product shows its own icon and other products the icon of their category, as the Google Cloud product icon guide assigns them. A product the guide does not list takes its category from the Google Cloud products catalog, so Cloud Source Repositories draws the Developer Tools category icon. A GKE node pool draws Compute Engine, the compute that backs it, as AKS node pools and EKS node groups draw theirs. Nineteen Rules keep a neutral symbol because the icon library has no icon for their product, among them the Google Cloud project, Firebase Realtime Database and multicast. Concepts shared by products with different icons, or produced by no Rule, keep their generic identity.Only the presentation catalog changes: Rules, Facts and comparisons are untouched. The Playground presentation files, in
examples/playground/formsand in the reference runtime fixtures, follow the new catalog with their manifest digests.Validation
bun run check: 307 tests pass.bun scripts/ci/run.ts dialects scenarioswith the reference runtime0.1.0-pr.117.1: 96 planned fixtures replay, Dialect verification passes, and the six Playground plan inputs with their saved plans, the three analysis and three comparison Forms and the nine pinned renderer inputs reproduce.google/*identities the catalog names has an icon in the renderer icon pack, and the pack draws nogoogle/*identity the catalog leaves out.