Repository navigation
refactor(dialects): fold the evidence directory into fixtures - #29
Merged
Merged
Conversation
- Move each Dialect's reviewed scenarios to fixtures/expectations and the plan fixture inventory to fixtures/inventory.json, unchanged. - Move the provider registry equivalence beside dialects.json. - Remove the research snapshots and spike notes that no script generates, reads or refreshes; git history keeps them. - The validator accepts only the inventory and one expectations file per official Dialect beside the fixtures, and checks their fixture and Rule references.
Contributor
Contribution progressSource: Selected validations:
Applicable consumers are synchronized on their development branches and the staging sites. Releases are published from main; the Release row follows them. |
Contributor
Author
|
/rootform retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
dialects/now holds the official Dialects, their metadata files and onefixtures/directory. Theevidence/directory is gone:evidence/<dialect>/scenarios.jsontofixtures/expectations/<dialect>.json, the plan fixture inventory tofixtures/inventory.json, and the provider registry equivalence toprovider-registry-equivalence.json, besidedialects.json.Support files stay outside the Dialect directories, which keep only what
rootform packagepublishes. The validator now accepts, beside the fixture directories, only the inventory and one expectations file per official Dialect; it checks that every scenario names an existing fixture and that the inventory and the expectations name declared Rules. Dialect sources, fixtures and goldens are unchanged, so the embedded release set and every analysis stay identical.Validation
bun run check: 306 tests pass; repository and Dialect structure valid.bun scripts/ci/run.ts dialects scenarioswith the reference runtime0.1.0-pr.117.1: 96 planned fixtures replay, every scenario expectation holds against its golden with none naming an unplanned fixture, and the Playground inputs, Forms and nine pinned renderer inputs reproduce.fixtures/, an expectations file for an unknown Dialect and a top-levelevidence/directory.