Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the fixes described in #76 and #77 (both in
lib/Service/AuthRoundCube.php):logout(): fetch the current request token from the active Roundcube session before posting the logout, so Roundcube no longer rejects it with "Request security check failed" ("Request security check failed" Nextcloud-Logout leaves Roundcube logged in #76).sendRequest(): always exactly one/between the Roundcube location and the query, with or without a trailing slash in the configured location (sendRequest(): double slash or missing slash depending on trailing slash in Roundcube location #77).Tested with Nextcloud 34.0.4, mail_roundcube 1.3.0 and Roundcube 1.6.18 (CSRF check enabled).
Fixes #76
Fixes #77