Repository navigation
Conversation
…h the same name Fixes rotdrop#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
Before generating a new
z-app-generated-roundcubeapp password,AppPasswordService::generateAppPassword()now invalidates the user's existingpermanent tokens with the same name. The new token replaces the old one in the
CardDAV account right afterwards, so the old one is no longer needed.
Without this, every login adds another valid permanent token and the old ones
are never removed (61 accumulated in our setup).
Tested: after one logout/login with the patch applied, exactly one token remains,
the CardDAV address book in Roundcube works, and there are no new log entries.